Leverage non-capturing catches

Author: fancyweb

Lock.php

@@ -84,7 +84,7 @@ public function acquire(bool $blocking = false): bool
                         try {
                             $this->store->save($this->key);
                             break;
-                        } catch (LockConflictedException $e) {
+                        } catch (LockConflictedException) {
                             usleep((100 + random_int(-10, 10)) * 1000);
                         }
                     }
@@ -105,7 +105,7 @@ public function acquire(bool $blocking = false): bool
             if ($this->key->isExpired()) {
                 try {
                     $this->release();
-                } catch (\Exception $e) {
+                } catch (\Exception) {
                     // swallow exception to not hide the original issue
                 }
                 throw new LockExpiredException(sprintf('Failed to store the "%s" lock.', $this->key));
@@ -145,7 +145,7 @@ public function acquireRead(bool $blocking = false): bool
                         try {
                             $this->store->saveRead($this->key);
                             break;
-                        } catch (LockConflictedException $e) {
+                        } catch (LockConflictedException) {
                             usleep((100 + random_int(-10, 10)) * 1000);
                         }
                     }
@@ -166,7 +166,7 @@ public function acquireRead(bool $blocking = false): bool
             if ($this->key->isExpired()) {
                 try {
                     $this->release();
-                } catch (\Exception $e) {
+                } catch (\Exception) {
                     // swallow exception to not hide the original issue
                 }
                 throw new LockExpiredException(sprintf('Failed to store the "%s" lock.', $this->key));
@@ -208,7 +208,7 @@ public function refresh(float $ttl = null)
             if ($this->key->isExpired()) {
                 try {
                     $this->release();
-                } catch (\Exception $e) {
+                } catch (\Exception) {
                     // swallow exception to not hide the original issue
                 }
                 throw new LockExpiredException(sprintf('Failed to put off the expiration of the "%s" lock within the specified time.', $this->key));

Store/DoctrineDbalPostgreSqlStore.php

@@ -141,7 +141,7 @@ public function delete(Key $key)
             // If lock acquired = there is no other ReadLock
             $store->save($key);
             $this->unlockShared($key);
-        } catch (LockConflictedException $e) {
+        } catch (LockConflictedException) {
             // an other key exists in this ReadLock
         }
 

Store/DoctrineDbalStore.php

@@ -89,7 +89,7 @@ public function save(Key $key)
                 ParameterType::STRING,
                 ParameterType::STRING,
             ]);
-        } catch (TableNotFoundException $e) {
+        } catch (TableNotFoundException) {
             if (!$this->conn->isTransactionActive() || $this->platformSupportsTableCreationInTransaction()) {
                 $this->createTable();
             }
@@ -102,10 +102,10 @@ public function save(Key $key)
                     ParameterType::STRING,
                     ParameterType::STRING,
                 ]);
-            } catch (DBALException $e) {
+            } catch (DBALException) {
                 $this->putOffExpiration($key, $this->initialTtl);
             }
-        } catch (DBALException $e) {
+        } catch (DBALException) {
             // the lock is already acquired. It could be us. Let's try to put off.
             $this->putOffExpiration($key, $this->initialTtl);
         }

Store/ExpiringStoreTrait.php

@@ -21,7 +21,7 @@ private function checkNotExpired(Key $key)
         if ($key->isExpired()) {
             try {
                 $this->delete($key);
-            } catch (\Exception $e) {
+            } catch (\Exception) {
                 // swallow exception to not hide the original issue
             }
             throw new LockExpiredException(sprintf('Failed to store the "%s" lock.', $key));

Store/PdoStore.php

@@ -94,7 +94,7 @@ public function save(Key $key)
         $conn = $this->getConnection();
         try {
             $stmt = $conn->prepare($sql);
-        } catch (\PDOException $e) {
+        } catch (\PDOException) {
             if (!$conn->inTransaction() || \in_array($this->driver, ['pgsql', 'sqlite', 'sqlsrv'], true)) {
                 $this->createTable();
             }
@@ -106,7 +106,7 @@ public function save(Key $key)
 
         try {
             $stmt->execute();
-        } catch (\PDOException $e) {
+        } catch (\PDOException) {
             // the lock is already acquired. It could be us. Let's try to put off.
             $this->putOffExpiration($key, $this->initialTtl);
         }

Store/PostgreSqlStore.php

@@ -156,7 +156,7 @@ public function delete(Key $key)
             // If lock acquired = there is no other ReadLock
             $store->save($key);
             $this->unlockShared($key);
-        } catch (LockConflictedException $e) {
+        } catch (LockConflictedException) {
             // an other key exists in this ReadLock
         }
 

Store/ZookeeperStore.php

@@ -100,7 +100,7 @@ public function exists(Key $key): bool
         $resource = $this->getKeyResource($key);
         try {
             return $this->zookeeper->get($resource) === $this->getUniqueToken($key);
-        } catch (\ZookeeperException $ex) {
+        } catch (\ZookeeperException) {
             return false;
         }
     }