Merge branch '5.4' into 6.2

* 5.4:
  Migrate to `static` data providers using `rector/rector`

Author: nicolas-grekas

Tests/LockTest.php

@@ -434,7 +434,7 @@ public function testExpirationStoreInterface($ttls, $expected)
         $this->assertSame($expected, $lock->isExpired());
     }
 
-    public function provideExpiredDates()
+    public static function provideExpiredDates()
     {
         yield [[-0.1], true];
         yield [[0.1, -0.1], true];

Tests/Store/DoctrineDbalPostgreSqlStoreTest.php

@@ -60,7 +60,7 @@ public function testInvalidDriver($connOrDsn)
         $store->exists(new Key('foo'));
     }
 
-    public function getInvalidDrivers()
+    public static function getInvalidDrivers()
     {
         yield ['sqlite:///tmp/foo.db'];
         yield [DriverManager::getConnection(['url' => 'sqlite:///tmp/foo.db'])];

Tests/Store/DoctrineDbalStoreTest.php

@@ -79,7 +79,7 @@ public function testDsn(string $dsn, string $file = null)
         }
     }
 
-    public function provideDsn()
+    public static function provideDsn()
     {
         $dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache');
         yield ['sqlite://localhost/'.$dbFile.'1', $dbFile.'1'];
@@ -127,7 +127,7 @@ public function testCreatesTableInTransaction(string $platform)
         $store->save($key);
     }
 
-    public function providePlatforms()
+    public static function providePlatforms()
     {
         yield [\Doctrine\DBAL\Platforms\PostgreSQLPlatform::class];
         yield [\Doctrine\DBAL\Platforms\PostgreSQL94Platform::class];

Tests/Store/MongoDbStoreTest.php

@@ -94,7 +94,7 @@ public function testConstructionMethods($mongo, array $options)
         $this->assertFalse($store->exists($key));
     }
 
-    public function provideConstructorArgs()
+    public static function provideConstructorArgs()
     {
         $client = self::getMongoClient();
         yield [$client, ['database' => 'test', 'collection' => 'lock']];
@@ -134,7 +134,7 @@ public function testInvalidConstructionMethods($mongo, array $options)
         new MongoDbStore($mongo, $options);
     }
 
-    public function provideInvalidConstructorArgs()
+    public static function provideInvalidConstructorArgs()
     {
         $client = self::getMongoClient();
         yield [$client, ['collection' => 'lock']];
@@ -160,7 +160,7 @@ public function testUriCollectionStrip(string $uri, array $options, string $driv
         $this->assertSame($driverUri, $uri);
     }
 
-    public function provideUriCollectionStripArgs()
+    public static function provideUriCollectionStripArgs()
     {
         yield ['mongodb://localhost/?collection=lock', ['database' => 'test'], 'mongodb://localhost/'];
         yield ['mongodb://localhost/', ['database' => 'test', 'collection' => 'lock'], 'mongodb://localhost/'];

Tests/Store/PdoStoreTest.php

@@ -89,7 +89,7 @@ public function testDsn(string $dsn, string $file = null)
         }
     }
 
-    public function provideDsn()
+    public static function provideDsn()
     {
         $dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache');
         yield ['sqlite:'.$dbFile.'2', $dbFile.'2'];

Tests/Store/ZookeeperStoreTest.php

@@ -42,7 +42,7 @@ public function testCreateConnection(string $connectionString)
         $this->assertInstanceOf(\Zookeeper::class, ZookeeperStore::createConnection($connectionString));
     }
 
-    public function provideValidConnectionString(): iterable
+    public static function provideValidConnectionString(): iterable
     {
         yield 'single host' => ['zookeeper://localhost:2181'];
         yield 'single multiple host' => ['zookeeper://localhost:2181,localhost:2181'];

Tests/Strategy/ConsensusStrategyTest.php

@@ -27,7 +27,7 @@ protected function setUp(): void
         $this->strategy = new ConsensusStrategy();
     }
 
-    public function provideMetResults()
+    public static function provideMetResults()
     {
         // success, failure, total, isMet
         yield [3, 0, 3, true];
@@ -49,7 +49,7 @@ public function provideMetResults()
         yield [0, 0, 2, false];
     }
 
-    public function provideIndeterminate()
+    public static function provideIndeterminate()
     {
         // success, failure, total, canBeMet
         yield [3, 0, 3, true];

Tests/Strategy/UnanimousStrategyTest.php

@@ -27,7 +27,7 @@ protected function setUp(): void
         $this->strategy = new UnanimousStrategy();
     }
 
-    public function provideMetResults()
+    public static function provideMetResults()
     {
         // success, failure, total, isMet
         yield [3, 0, 3, true];
@@ -49,7 +49,7 @@ public function provideMetResults()
         yield [0, 0, 2, false];
     }
 
-    public function provideIndeterminate()
+    public static function provideIndeterminate()
     {
         // success, failure, total, canBeMet
         yield [3, 0, 3, true];