use constructor property promotion

Author: xabbuh

Command/UserPasswordHashCommand.php

@@ -38,14 +38,10 @@
 #[AsCommand(name: 'security:hash-password', description: 'Hash a user password')]
 class UserPasswordHashCommand extends Command
 {
-    private PasswordHasherFactoryInterface $hasherFactory;
-    private array $userClasses;
-
-    public function __construct(PasswordHasherFactoryInterface $hasherFactory, array $userClasses = [])
-    {
-        $this->hasherFactory = $hasherFactory;
-        $this->userClasses = $userClasses;
-
+    public function __construct(
+        private PasswordHasherFactoryInterface $hasherFactory,
+        private array $userClasses = [],
+    ) {
         parent::__construct();
     }
 

Hasher/MessageDigestPasswordHasher.php

@@ -24,28 +24,23 @@ class MessageDigestPasswordHasher implements LegacyPasswordHasherInterface
 {
     use CheckPasswordLengthTrait;
 
-    private string $algorithm;
-    private bool $encodeHashAsBase64;
-    private int $iterations = 1;
     private int $hashLength = -1;
 
     /**
      * @param string $algorithm          The digest algorithm to use
      * @param bool   $encodeHashAsBase64 Whether to base64 encode the password hash
      * @param int    $iterations         The number of iterations to use to stretch the password hash
      */
-    public function __construct(string $algorithm = 'sha512', bool $encodeHashAsBase64 = true, int $iterations = 5000)
-    {
-        $this->algorithm = $algorithm;
-        $this->encodeHashAsBase64 = $encodeHashAsBase64;
-
+    public function __construct(
+        private string $algorithm = 'sha512',
+        private bool $encodeHashAsBase64 = true,
+        private int $iterations = 5000,
+    ) {
         try {
             $this->hashLength = \strlen($this->hash('', 'salt'));
         } catch (\LogicException) {
             // ignore algorithm not supported
         }
-
-        $this->iterations = $iterations;
     }
 
     public function hash(#[\SensitiveParameter] string $plainPassword, ?string $salt = null): string

Hasher/MigratingPasswordHasher.php

@@ -24,12 +24,12 @@
  */
 final class MigratingPasswordHasher implements PasswordHasherInterface
 {
-    private PasswordHasherInterface $bestHasher;
     private array $extraHashers;
 
-    public function __construct(PasswordHasherInterface $bestHasher, PasswordHasherInterface ...$extraHashers)
-    {
-        $this->bestHasher = $bestHasher;
+    public function __construct(
+        private PasswordHasherInterface $bestHasher,
+        PasswordHasherInterface ...$extraHashers,
+    ) {
         $this->extraHashers = $extraHashers;
     }
 

Hasher/PasswordHasherFactory.php

@@ -23,14 +23,12 @@
  */
 class PasswordHasherFactory implements PasswordHasherFactoryInterface
 {
-    private array $passwordHashers;
-
     /**
      * @param array<string, PasswordHasherInterface|array> $passwordHashers
      */
-    public function __construct(array $passwordHashers)
-    {
-        $this->passwordHashers = $passwordHashers;
+    public function __construct(
+        private array $passwordHashers,
+    ) {
     }
 
     public function getPasswordHasher(string|PasswordAuthenticatedUserInterface|PasswordHasherAwareInterface $user): PasswordHasherInterface

Hasher/Pbkdf2PasswordHasher.php

@@ -32,10 +32,6 @@ final class Pbkdf2PasswordHasher implements LegacyPasswordHasherInterface
 {
     use CheckPasswordLengthTrait;
 
-    private string $algorithm;
-    private bool $encodeHashAsBase64;
-    private int $iterations = 1;
-    private int $length;
     private int $encodedLength = -1;
 
     /**
@@ -44,19 +40,17 @@ final class Pbkdf2PasswordHasher implements LegacyPasswordHasherInterface
      * @param int    $iterations         The number of iterations to use to stretch the password hash
      * @param int    $length             Length of derived key to create
      */
-    public function __construct(string $algorithm = 'sha512', bool $encodeHashAsBase64 = true, int $iterations = 1000, int $length = 40)
-    {
-        $this->algorithm = $algorithm;
-        $this->encodeHashAsBase64 = $encodeHashAsBase64;
-        $this->length = $length;
-
+    public function __construct(
+        private string $algorithm = 'sha512',
+        private bool $encodeHashAsBase64 = true,
+        private int $iterations = 1000,
+        private int $length = 40,
+    ) {
         try {
             $this->encodedLength = \strlen($this->hash('', 'salt'));
         } catch (\LogicException) {
             // ignore unsupported algorithm
         }
-
-        $this->iterations = $iterations;
     }
 
     public function hash(#[\SensitiveParameter] string $plainPassword, ?string $salt = null): string

Hasher/PlaintextPasswordHasher.php

@@ -25,14 +25,12 @@ class PlaintextPasswordHasher implements LegacyPasswordHasherInterface
 {
     use CheckPasswordLengthTrait;
 
-    private bool $ignorePasswordCase;
-
     /**
      * @param bool $ignorePasswordCase Compare password case-insensitive
      */
-    public function __construct(bool $ignorePasswordCase = false)
-    {
-        $this->ignorePasswordCase = $ignorePasswordCase;
+    public function __construct(
+        private bool $ignorePasswordCase = false,
+    ) {
     }
 
     public function hash(#[\SensitiveParameter] string $plainPassword, ?string $salt = null): string

Hasher/UserPasswordHasher.php

@@ -23,11 +23,9 @@
  */
 class UserPasswordHasher implements UserPasswordHasherInterface
 {
-    private PasswordHasherFactoryInterface $hasherFactory;
-
-    public function __construct(PasswordHasherFactoryInterface $hasherFactory)
-    {
-        $this->hasherFactory = $hasherFactory;
+    public function __construct(
+        private PasswordHasherFactoryInterface $hasherFactory,
+    ) {
     }
 
     public function hashPassword(PasswordAuthenticatedUserInterface $user, #[\SensitiveParameter] string $plainPassword): string