[ExpressionLanguage][PasswordHasher][Stopwatch] Improve overall coverage

Author: alexandre-daubois

Tests/Hasher/MessageDigestPasswordHasherTest.php

@@ -60,4 +60,12 @@ public function testCheckPasswordLength()
 
         $this->assertFalse($hasher->verify('encoded', str_repeat('a', 5000), 'salt'));
     }
+
+    public function testUsingBracketInSaltThrows()
+    {
+        $hasher = new MessageDigestPasswordHasher('sha256', false, 1);
+
+        $this->expectException(\LogicException::class);
+        $hasher->hash('password', '{');
+    }
 }

Tests/Hasher/NativePasswordHasherTest.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\PasswordHasher\Tests\Hasher;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\PasswordHasher\Exception\InvalidPasswordException;
 use Symfony\Component\PasswordHasher\Hasher\NativePasswordHasher;
 
 /**
@@ -119,4 +120,40 @@ public function testNeedsRehash()
         $hasher = new NativePasswordHasher(5, 11000, 5);
         $this->assertTrue($hasher->needsRehash($hash));
     }
+
+    public function testLowOpsLimitsThrows()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessageMatches('/\$opsLimit must be (\d+) or greater\./');
+
+        new NativePasswordHasher(2);
+    }
+
+    public function testLowMemLimitThrows()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessageMatches('/\$memLimit must be (\d+)(.?) or greater\./');
+
+        new NativePasswordHasher(3, 9999);
+    }
+
+    /**
+     * @testWith [1]
+     *           [40]
+     */
+    public function testInvalidCostThrows(int $cost)
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessageMatches('/\$cost must be in the range of (\d+)-(\d+)\./');
+
+        new NativePasswordHasher(4, 11000, $cost);
+    }
+
+    public function testHashTooLongPasswordThrows()
+    {
+        $this->expectException(InvalidPasswordException::class);
+
+        $hasher = new NativePasswordHasher(4, 11000, 4);
+        $hasher->hash(str_repeat('a', 5000));
+    }
 }

Tests/Hasher/PasswordHasherFactoryTest.php

@@ -175,6 +175,22 @@ public function testMigrateFrom()
         $this->assertStringStartsWith(\SODIUM_CRYPTO_PWHASH_STRPREFIX, $hasher->hash('foo', null));
     }
 
+    public function testMissingClass()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('"class" must be set in {"arguments":[]}');
+
+        (new PasswordHasherFactory([SomeUser::class => ['arguments' => []]]))->getPasswordHasher(SomeUser::class);
+    }
+
+    public function testMissingArguments()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('"arguments" must be set in {"class":"stdClass"}');
+
+        (new PasswordHasherFactory([SomeUser::class => ['class' => \stdClass::class]]))->getPasswordHasher(SomeUser::class);
+    }
+
     public function testDefaultMigratingHashers()
     {
         $this->assertInstanceOf(

Tests/Hasher/PlaintextPasswordHasherTest.php

@@ -53,4 +53,12 @@ public function testCheckPasswordLength()
 
         $this->assertFalse($hasher->verify('encoded', str_repeat('a', 5000), 'salt'));
     }
+
+    public function testUsingBracketInSaltThrows()
+    {
+        $hasher = new PlaintextPasswordHasher();
+
+        $this->expectException(\LogicException::class);
+        $hasher->hash('password', '{');
+    }
 }