Leverage non-capturing catches

fancyweb · fancyweb · commit e7520cd56cf7 · 2022-04-01T09:15:35.000+02:00
diff --git a/Hasher/MessageDigestPasswordHasher.php b/Hasher/MessageDigestPasswordHasher.php
@@ -41,7 +41,7 @@ public function __construct(string $algorithm = 'sha512', bool $encodeHashAsBase
 
         try {
             $this->hashLength = \strlen($this->hash('', 'salt'));
-        } catch (\LogicException $e) {
+        } catch (\LogicException) {
             // ignore algorithm not supported
         }
 
diff --git a/Hasher/Pbkdf2PasswordHasher.php b/Hasher/Pbkdf2PasswordHasher.php
@@ -52,7 +52,7 @@ public function __construct(string $algorithm = 'sha512', bool $encodeHashAsBase
 
         try {
             $this->encodedLength = \strlen($this->hash('', 'salt'));
-        } catch (\LogicException $e) {
+        } catch (\LogicException) {
             // ignore unsupported algorithm
         }
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function __construct(string $algorithm = 'sha512', bool $encodeHashAsBase`
`41`	`41`
`42`	`42`	`try {`
`43`	`43`	`$this->hashLength = \strlen($this->hash('', 'salt'));`
`44`		`- } catch (\LogicException $e) {`
	`44`	`+ } catch (\LogicException) {`
`45`	`45`	`// ignore algorithm not supported`
`46`	`46`	`}`
`47`	`47`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function __construct(string $algorithm = 'sha512', bool $encodeHashAsBase`
`52`	`52`
`53`	`53`	`try {`
`54`	`54`	`$this->encodedLength = \strlen($this->hash('', 'salt'));`
`55`		`- } catch (\LogicException $e) {`
	`55`	`+ } catch (\LogicException) {`
`56`	`56`	`// ignore unsupported algorithm`
`57`	`57`	`}`
`58`	`58`