Commit cfa1442
committed
minor #13986 Fix OPcache class preload requirement (ITernovtsiy)
This PR was merged into the 4.4 branch.
Discussion
----------
Fix OPcache class preload requirement
`container.dumper.inline_factories`
As stated by @nicolas-grekas in symfony/symfony#32581 (comment)
> With preloading, a single big file can, in theory, be similarly fast or faster.
`container.dumper.inline_class_loader`
With this parameter set to `true`, we'll do extra `include_once` for classes already preloaded by OPcache.
Additionally, it can lead to warnings (cannot redeclare class) in classes that use `class_alias`, like https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/master/src/EventListener/InvalidationListener.php#L33
It's because this class already declared in preload, and PHP tries to declare it again after `include_once` in service getter.
Commits
-------
cc151fc Remove incorrect opcache preload instructions1 file changed
+1
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
113 | | - | |
114 | | - | |
| 112 | + | |
115 | 113 | | |
116 | 114 | | |
117 | 115 | | |
| |||
0 commit comments