[Idea/Feature Request]: Possibly to include other folders

[nunoidev]

A really cool feature I'd like to request in the next release:

A preference domain option (plist or mobileconfig) to allow additional folders in the User profile for syncing in addition to exclude or include documents and desktop, e.g.

defaults write "/Library/Preferences/com.cambridgeconsultants.onedrive-kfm" SyncDesktopFolder -bool YES
defaults write "/Library/Preferences/com.cambridgeconsultants.onedrive-kfm" SyncDocumentsFolder -bool YES
defaults write "/Library/Preferences/com.cambridgeconsultants.onedrive-kfm" SyncPicturesFolder -bool YES
defaults write "/Library/Preferences/com.cambridgeconsultants.onedrive-kfm" SyncMoviesFolder-bool YES
defaults write "/Library/Preferences/com.cambridgeconsultants.onedrive-kfm" SyncMusicFolder -bool YES
defaults write "/Library/Preferences/com.cambridgeconsultants.onedrive-kfm" SyncDownloadsFolder -bool YES

I understand this might require additional script coding to read the preferences and perform the symlink checks, but this feature would then become in-line with Windows GPO where you can select which folders in the user Profile to sync.

Thanks.

[nunoidev]

Update: I forked out this repo and updated the logic to include the feature request, it is located in: https://github.com/nunoidev/MacOS-OneDrive-KFM/

Would love to have someone test this feature and/or advise issues and corrections for merging consideration.
Code changes done: onedrive-kfm.sh (located in outset login-privileged-every) and README.md

I've tested myself and while it works on my device, I've encountered an issue with "Show in Finder is not working because Finder.app is not available"; either way the script configured the folders I wanted to sync.

[samspade21]

I like it. I will test what you have done, and another fork that was made and look to incorporate them back into this project. Good stuff!

[anxanywhere]

Hi @nunoidev and @samspade21, very nicely done.

One suggestion:

Under the assumption that some people may have already the master branch installed and running, in the absence of SyncDesktopFolder, SyncDocumentsFolder, SyncPicturesFolder, SyncMoviesFolder, SyncMusicFolder and SyncDownloadsFolder in preference plots, this branch should assume True for SyncDesktopFolder and SyncDocumentsFolder, and False to other folders.

This will ensure that the preferences plots [/Library/Preferences/com.cambridgeconsultants.onedrive-kfm] that doesn't references none of 6 possible folders will continue working as expected by the master branch.

Br,
ANx

[anxanywhere]

I'm running macOS Catalina and found some issues in /usr/local/outset/login-privileged-every/onedrive-kfm.sh:

/usr/local/outset/login-privileged-every/onedrive-kfm.sh: line 89: [: True: integer expression expected
/usr/local/outset/login-privileged-every/onedrive-kfm.sh: line 103: [: True: integer expression expected
/usr/local/outset/login-privileged-every/onedrive-kfm.sh: line 117: [: False: integer expression expected
/usr/local/outset/login-privileged-every/onedrive-kfm.sh: line 131: [: False: integer expression expected
/usr/local/outset/login-privileged-every/onedrive-kfm.sh: line 145: [: False: integer expression expected
/usr/local/outset/login-privileged-every/onedrive-kfm.sh: line 159: [: False: integer expression expected

Fixed locally by replacing -eq by == when comparing values of syncDesktopFolder, syncDocumentsFolder, syncPicturesFolder, syncMoviesFolder, syncMusicFolder and syncDownloadsFolder:

            #if [ "$syncDesktopFolder" -eq "True" ]; then
            if [ "$syncDesktopFolder" == "True" ]; then

            #if [ "$syncDocumentsFolder" -eq "True" ]; then
            if [ "$syncDocumentsFolder" == "True" ]; then

            #if [ "$syncPicturesFolder" -eq "True" ]; then
            if [ "$syncPicturesFolder" == "True" ]; then

            #if [ "$syncMoviesFolder" -eq "True" ]; then
            if [ "$syncMoviesFolder" == "True" ]; then

            #if [ "$syncMusicFolder" -eq "True" ]; then
            if [ "$syncMusicFolder" == "True" ]; then

            #if [ "$syncDownloadsFolder" -eq "True" ]; then
            if [ "$syncDownloadsFolder" == "True" ]; then

Br,
ANx

[maysarh]

I'm not a professional here, but I followed the steps except the last step for building the package, I really don't know how to make it.
I'm coping the git https and trying to paste in terminal with git clone but it showing this message:

fatal: destination path 'MacOS-OneDrive-KFM' already exists and is not an empty directory.

even I can't understand the note for Munki-pkg "ensure it is in your path" I only got the munkitools-5.5.0.4362.pkg and directly install it.

appreciate your support here. 🙏🏻

[fixem73]

Been doing some testing as I have several users that have HUGE file directories and loved to use special characters to help sort and this works great with one big drawback. It overwrites the file if then only difference was special characters.

Anyone figure out how to deny overwrites, popup? (Keep both) or an option to add -copy
Example:
badfile1STCopy"|
badfile1STCopy<>
After the script you end up with only 1 file with the contents of the last file.