Suppress Cppcheck warnings: arithOperationsOnVoidPointer

Cppcheck was complaining:
> When using void pointers in calculations, the behaviour is undefined.
> [arithOperationsOnVoidPointer]

Author: jserv

src/pci.c

@@ -11,7 +11,7 @@ static void pci_address_io(void *owner,
                            uint8_t size)
 {
     struct pci *pci = (struct pci *) owner;
-    void *p = (void *) &pci->pci_addr + offset;
+    void *p = (void *) ((uintptr_t) &pci->pci_addr + offset);
     /* The data in port 0xCF8 is as an address when Guest Linux accesses the
      * configuration space.
      */
@@ -81,7 +81,7 @@ static void pci_config_write(struct pci_dev *dev,
                              uint64_t offset,
                              uint8_t size)
 {
-    void *p = dev->hdr + offset;
+    void *p = (void *) ((uintptr_t) dev->hdr + offset);
 
     memcpy(p, data, size);
     if (offset == PCI_COMMAND) {
@@ -100,7 +100,7 @@ static void pci_config_read(struct pci_dev *dev,
                             uint64_t offset,
                             uint8_t size)
 {
-    void *p = dev->hdr + offset;
+    void *p = (void *) ((uintptr_t) dev->hdr + offset);
     memcpy(data, p, size);
 }
 

src/pci.h

@@ -19,9 +19,10 @@ union pci_config_address {
     uint32_t value;
 };
 
-#define PCI_HDR_READ(hdr, offset, width) (*((uint##width##_t *) (hdr + offset)))
+#define PCI_HDR_READ(hdr, offset, width) \
+    (*((uint##width##_t *) ((uintptr_t) hdr + offset)))
 #define PCI_HDR_WRITE(hdr, offset, value, width) \
-    ((uint##width##_t *) (hdr + offset))[0] = value
+    ((uint##width##_t *) ((uintptr_t) hdr + offset))[0] = value
 #define PCI_BAR_OFFSET(bar) (PCI_BASE_ADDRESS_0 + ((bar) << 2))
 
 struct pci_dev {

src/virtio-pci.c

@@ -64,7 +64,7 @@ static void virtio_pci_select_virtq(struct virtio_pci_dev *dev)
 
     if (select < config->num_queues) {
         uint64_t offset = offsetof(struct virtio_pci_common_cfg, queue_size);
-        memcpy((void *) config + offset, &dev->vq[select].info,
+        memcpy((void *) ((uintptr_t) config + offset), &dev->vq[select].info,
                sizeof(struct virtq_info));
     } else {
         config->queue_size = 0;
@@ -89,7 +89,7 @@ static void virtio_pci_space_write(struct virtio_pci_dev *dev,
                                    uint8_t size)
 {
     if (offset < offsetof(struct virtio_pci_config, dev_cfg)) {
-        memcpy((void *) &dev->config + offset, data, size);
+        memcpy((void *) ((uintptr_t) &dev->config + offset), data, size);
         switch (offset) {
         case VIRTIO_PCI_COMMON_DFSELECT:
             virtio_pci_select_device_feature(dev);
@@ -115,8 +115,9 @@ static void virtio_pci_space_write(struct virtio_pci_dev *dev,
                 uint16_t select = dev->config.common_cfg.queue_select;
                 uint64_t info_offset = offset - VIRTIO_PCI_COMMON_Q_SIZE;
                 if (select < dev->config.common_cfg.num_queues)
-                    memcpy((void *) &dev->vq[select].info + info_offset, data,
-                           size);
+                    memcpy((void *) ((uintptr_t) &dev->vq[select].info +
+                                     info_offset),
+                           data, size);
             }
             /* guest notify buffer avail */
             else if (offset ==
@@ -129,7 +130,7 @@ static void virtio_pci_space_write(struct virtio_pci_dev *dev,
     }
     /* dev config write */
     uint64_t dev_offset = offset - offsetof(struct virtio_pci_config, dev_cfg);
-    memcpy((void *) dev->config.dev_cfg + dev_offset, data, size);
+    memcpy((void *) ((uintptr_t) dev->config.dev_cfg + dev_offset), data, size);
 }
 
 static void virtio_pci_space_read(struct virtio_pci_dev *dev,
@@ -138,15 +139,16 @@ static void virtio_pci_space_read(struct virtio_pci_dev *dev,
                                   uint8_t size)
 {
     if (offset < offsetof(struct virtio_pci_config, dev_cfg)) {
-        memcpy(data, (void *) &dev->config + offset, size);
+        memcpy(data, (void *) ((uintptr_t) &dev->config + offset), size);
         if (offset == offsetof(struct virtio_pci_config, isr_cap)) {
             dev->config.isr_cap.isr_status = 0;
         }
     } else {
         /* dev config read */
         uint64_t dev_offset =
             offset - offsetof(struct virtio_pci_config, dev_cfg);
-        memcpy(data, (void *) dev->config.dev_cfg + dev_offset, size);
+        memcpy(data, (void *) ((uintptr_t) dev->config.dev_cfg + dev_offset),
+               size);
     }
 }
 
@@ -169,7 +171,8 @@ static void virtio_pci_set_cap(struct virtio_pci_dev *dev, uint8_t next)
     struct virtio_pci_cap *caps[VIRTIO_PCI_CAP_NUM + 1];
 
     for (int i = 1; i < VIRTIO_PCI_CAP_NUM + 1; i++) {
-        caps[i] = dev->pci_dev.hdr + next;
+        caps[i] =
+            (struct virtio_pci_cap *) ((uintptr_t) dev->pci_dev.hdr + next);
         *caps[i] = (struct virtio_pci_cap){
             .cap_vndr = PCI_CAP_ID_VNDR,
             .cfg_type = i,
@@ -280,4 +283,4 @@ void virtio_pci_enable(struct virtio_pci_dev *dev)
 void virtio_pci_exit()
 {
     /* TODO: exit of the virtio pci device */
-}
+}

src/vm.c

@@ -100,7 +100,7 @@ int vm_load_diskimg(vm_t *v, const char *diskimg_file)
 void vm_handle_io(vm_t *v, struct kvm_run *run)
 {
     uint64_t addr = run->io.port;
-    void *data = (void *) run + run->io.data_offset;
+    void *data = (void *) ((uintptr_t) run + run->io.data_offset);
     bool is_write = run->io.direction == KVM_EXIT_IO_OUT;
 
     for (int i = 0; i < run->io.count; i++) {