Skip to content

Move tools to subdirectory #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackpot51 merged 1 commit into from
Sep 8, 2025
Merged

Move tools to subdirectory #537

jackpot51 merged 1 commit into from
Sep 8, 2025

Conversation

@crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Aug 26, 2025

No description provided.

@crawfxrd crawfxrd requested review from a team August 26, 2025 16:45
@crawfxrd
Move tools to subdirectory
d3ce106 
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@jackpot51 jackpot51 merged commit 68befd3 into master Sep 8, 2025
51 checks passed
@jackpot51 jackpot51 deleted the tools-dir branch September 8, 2025 22:55
@jacobgkau
Copy link
Member

jacobgkau commented Sep 9, 2025 •
edited
Loading

Trying to make BOARD=system76/oryp5 flash_internal after this was merged, I got an error that manifest path tool/Cargo.toml does not exist. Soft-linking tool to tools/system76_ectool helped a little. I think something somewhere else wasn't updated to point to the new location.

@crawfxrd
Copy link
Member Author

crawfxrd commented Sep 9, 2025

Other targets in src/board/system76/common/common.mk need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

@leviport leviport leviport approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crawfxrd @jacobgkau @jackpot51 @leviport