Skip to content

solve virtio_inject_irq's concurrency issue #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KouweiLee merged 2 commits into from
Jan 20, 2026
Merged

solve virtio_inject_irq's concurrency issue #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da3037b
solve virtio_inject_irq's concurrency issue
liulog Jan 20, 2026
be3d026
clang-format
liulog Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tools/virtio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,10 +918,19 @@ void virtio_inject_irq(VirtQueue *vq) {
}
}
volatile struct device_res *res;
while (is_queue_full(virtio_bridge->res_front, virtio_bridge->res_rear,
MAX_REQ))
;

// virtio_bridge is a global resource located in shared memory.
// Access to critical resources such as res_front and res_rear requires
// locking.

// Since the shared resources related to res_list are only accessed
// at one specific code location, a lock before polling is_queue_full
// is enough to ensure thread safety and performance.
pthread_mutex_lock(&RES_MUTEX);

while (is_queue_full(virtio_bridge->res_front, virtio_bridge->res_rear,
MAX_REQ)) {
}
unsigned int res_rear = virtio_bridge->res_rear;
res = &virtio_bridge->res_list[res_rear];
res->irq_id = vq->dev->irq_id;
Expand Down