Omitting depends_on is overwritten with `tach sync`

[craigmulligan]

From the modules docs:

Omitting the depends_on field means the module will be allowed to import from any other module. However, it will still be subject to those modules' public interfaces.

This works well when running tach check it's respected and the dependencies are not checked. But when one runs tach sync and then tach check it writes the depends_on back to the config and so you have to manually edit it.

I think there should be a specific flag like unchecked_depends_on or something rather than relying on the omission.

[DetachHead]

does depends_on = ["**"] work for you?

[craigmulligan]

does depends_on = ["**"] work for you?

No, given the following tach.toml

[[modules]]
path = "<root>"
depends_on = ["**"]

[[modules]]
path = "module_1"
depends_on = ["**"]

After a sync (assuming + module_1 depend on module_2.

[[modules]]
path = "<root>"
depends_on = ["module_2"]

[[modules]]
path = "module_1"
depends_on = ["**", "module_2"]

For whatever reason it treats <root> and "standard" modules differently. But both have the list of dependencies appended.

[DetachHead]

hmm looks like you need to set root_module = "allow" to be able to use <root> for some reason. see https://docs.gauge.sh/usage/configuration/#the-root-module

root_module = "allow"

[[modules]]
path = "<root>"
depends_on = ["**"]

[[modules]]
path = "module_1"
depends_on = ["**"]

[craigmulligan]

Hmm, we are using root_module = allow but it still yields the same result with depends_on = ["**"] being overwritten.

We have implemented our own tach sync command using the output of tach check --output=json for now, so this isn't an urgent issue for us atm.

[DetachHead]

if you could provide a minimal repro where root_module = "allow" isn't working i can take another look