Skip to content

Do not mark 'unit tests OK' in reviews when Unit Tests returned non-zero exit #12

@iamPHEN

Description

@iamPHEN

Currently the error code isn't being checked when unit tests are ran.

https://github.com/tagview/arcanist-extensions/blob/master/tap_test_engine/src/TAPTestEngine.php#L17

I have little understanding about PHP, but here's my hacky workaround:

    list($error, $stdout, $stderr) = $future->resolve();

    if ($error <> 0) {
      $msg = "not ok 0 - Unit test returned non-zero exit\n";
      echo $msg;
      return $this->parseOutput($msg);
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions