fix: remove type from imports and update ScrapboxResponse references

- Remove type keyword from imports where functions are used
- Update remaining ScrapboxResponse references to TargetedResponse in search.ts
- Fix unused imports across REST API files

Author: devin-ai-integration[bot]

rest/auth.ts

@@ -1,6 +1,6 @@
 import { getProfile } from "./profile.ts";
 import type { TargetedResponse } from "./targeted_response.ts";
-import { createErrorResponse, createSuccessResponse } from "./utils.ts";
+import { type createErrorResponse, createSuccessResponse } from "./utils.ts";
 import type { HTTPError } from "./responseIntoResult.ts";
 import type { AbortError, NetworkError } from "./robustFetch.ts";
 import type { ExtendedOptions } from "./options.ts";

rest/link.ts

@@ -7,6 +7,7 @@ import type {
 import { cookie } from "./auth.ts";
 import { parseHTTPError } from "./parseHTTPError.ts";
 import type { TargetedResponse } from "./targeted_response.ts";
+import { createErrorResponse, createSuccessResponse } from "./utils.ts";
 import { type BaseOptions, setDefaults } from "./options.ts";
 import type { FetchError } from "./mod.ts";
 

rest/page-data.ts

@@ -8,6 +8,7 @@ import type {
 import { cookie, getCSRFToken } from "./auth.ts";
 import { parseHTTPError } from "./parseHTTPError.ts";
 import type { TargetedResponse } from "./targeted_response.ts";
+import { createErrorResponse, createSuccessResponse } from "./utils.ts";
 import {
   type BaseOptions,
   type ExtendedOptions,

rest/pages.ts

@@ -11,6 +11,7 @@ import { parseHTTPError } from "./parseHTTPError.ts";
 import { encodeTitleURI } from "../title.ts";
 import { type BaseOptions, setDefaults } from "./options.ts";
 import type { TargetedResponse } from "./targeted_response.ts";
+import { createErrorResponse, createSuccessResponse } from "./utils.ts";
 import type { FetchError } from "./robustFetch.ts";
 
 /** Options for `getPage()` */

rest/parseHTTPError.ts

@@ -13,6 +13,7 @@ import { isLiteralOneOf } from "@core/unknownutil/is/literal-one-of";
 import { isRecord } from "@core/unknownutil/is/record";
 import { isString } from "@core/unknownutil/is/string";
 import type { TargetedResponse } from "./targeted_response.ts";
+import { createErrorResponse } from "./utils.ts";
 
 export interface RESTfullAPIErrorMap {
   BadRequestError: BadRequestError;

rest/profile.ts

@@ -2,8 +2,8 @@ import type { GuestUser, MemberUser } from "@cosense/types/rest";
 import { cookie } from "./auth.ts";
 import type { TargetedResponse } from "./targeted_response.ts";
 import {
-  createErrorResponse,
-  createSuccessResponse,
+  type createErrorResponse,
+  type createSuccessResponse,
   createTargetedResponse,
 } from "./utils.ts";
 import type { FetchError } from "./robustFetch.ts";
@@ -48,7 +48,7 @@ const getProfile_toRequest: GetProfile["toRequest"] = (
   );
 };
 
-const getProfile_fromResponse: GetProfile["fromResponse"] = async (res) => {
+const getProfile_fromResponse: GetProfile["fromResponse"] = (res) => {
   const response = createTargetedResponse<
     200 | 400 | 404,
     MemberUser | GuestUser | ProfileError

rest/search.ts

@@ -10,8 +10,8 @@ import { cookie } from "./auth.ts";
 import { parseHTTPError } from "./parseHTTPError.ts";
 import type { TargetedResponse } from "./targeted_response.ts";
 import {
-  createErrorResponse,
-  createSuccessResponse,
+  type createErrorResponse,
+  type createSuccessResponse,
   createTargetedResponse,
 } from "./utils.ts";
 import { type BaseOptions, setDefaults } from "./options.ts";
@@ -79,9 +79,9 @@ export const searchForJoinedProjects = async (
   query: string,
   init?: BaseOptions,
 ): Promise<
-  ScrapboxResponse<
-    ProjectSearchResult,
-    SearchForJoinedProjectsError | FetchError
+  TargetedResponse<
+    200 | 400 | 404,
+    ProjectSearchResult | SearchForJoinedProjectsError | FetchError
   >
 > => {
   const { sid, hostName, fetch } = setDefaults(init ?? {});
@@ -124,9 +124,9 @@ export const searchForWatchList = async (
   projectIds: string[],
   init?: BaseOptions,
 ): Promise<
-  ScrapboxResponse<
-    ProjectSearchResult,
-    SearchForWatchListError | FetchError
+  TargetedResponse<
+    200 | 400 | 404,
+    ProjectSearchResult | SearchForWatchListError | FetchError
   >
 > => {
   const { sid, hostName, fetch } = setDefaults(init ?? {});