Fixed a URI lookup with multiple replica sets

This patch fixed an issue where the URI lookup logic would terminate
prematurely if the instance was not found in the first replica set
when multiple replica sets were present.

Closes #427

Author: mandesero

CHANGELOG.md

@@ -4,6 +4,8 @@
 
 - Added an option to create `Cluster` objects without global hook management,
   allowing tests to keep clusters alive between test runs (gh-414).
+- Fixed a bug where URI search would terminate prematurely when multiple
+  replicasets existed (gh-427).
 
 ## 1.2.1
 

luatest/server.lua

@@ -153,7 +153,7 @@ local function find_advertise_uri(config, instance_name, dir)
         for _, replicaset in pairs(group.replicasets or {}) do
             local instance = (replicaset.instances or {})[instance_name]
             if instance == nil then
-                break
+                goto continue
             end
             if instance.iproto ~= nil then
                 if instance.iproto.advertise ~= nil then
@@ -173,6 +173,7 @@ local function find_advertise_uri(config, instance_name, dir)
                 end
                 listen = listen or group.iproto.listen
             end
+            ::continue::
         end
     end
 

test/server_test.lua

@@ -1,6 +1,7 @@
 local fio = require('fio')
 local json = require('json')
 local urilib = require('uri')
+local yaml = require('yaml')
 
 local t = require('luatest')
 local g = t.group()
@@ -492,6 +493,61 @@ g.after_test('test_no_socket_collision_with_duplicate_alias', function()
     g.s2:drop()
 end)
 
+g.test_net_box_uri_is_taken_from_matching_replicaset = function()
+    local tempdir = fio.tempdir()
+    local config_path = fio.pathjoin(tempdir, 'config.yaml')
+
+    local config = {
+        groups = {
+            ['group-001'] = {
+                replicasets = {
+                    ['rs-1'] = {
+                        iproto = {
+                            listen = {{
+                                uri = 'unix/:./{{ instance_name }}.iproto'
+                            }},
+                        },
+                        instances = {
+                            ['router-1'] = {},
+                        },
+                    },
+                    ['rs-2'] = {
+                        iproto = {
+                            listen = {{
+                                uri = 'unix/:./{{ instance_name }}.iproto'
+                            }},
+                        },
+                        instances = {
+                            ['storage-1'] = {},
+                        },
+                    },
+                },
+            },
+        },
+    }
+
+    local fh = fio.open(config_path, {'O_CREAT', 'O_WRONLY', 'O_TRUNC'},
+                        tonumber('644', 8))
+    fh:write(yaml.encode(config))
+    fh:close()
+
+    local s1 = Server:new({
+        alias = 'storage-1',
+        config_file = config_path,
+    })
+    local s2 = Server:new({
+        alias = 'router-1',
+        config_file = config_path,
+    })
+
+    t.assert_equals(s1.net_box_uri, 'unix/:nil/storage-1.iproto')
+    t.assert_equals(s2.net_box_uri, 'unix/:nil/router-1.iproto')
+    s1:drop()
+    s2:drop()
+
+    fio.rmtree(tempdir)
+end
+
 g.test_netbox_uri_is_not_overridden = function()
     local socket = ('%s/my-custom.sock'):format(Server.vardir)
     g.s1 = Server:new({net_box_uri = socket})