fix "Maximum call stack" error when resolving js files after css file… (#89)

* fix "Maximum call stack" error when resolving js files after css files. see teambit/bit#1431 for more info

* bump version

Author: David First

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [unreleased]
 
+## [2.0.2] - 2019-02-08
+
+- fix "Maximum call stack" error when resolving js files after css files
+
 ## [2.0.1] - 2019-02-04
 
 - fix parsing `.tsx` files

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bit-javascript",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "scripts": {
     "flow": "flow; test $? -eq 0 -o $? -eq 2",
     "lint": "eslint src && flow check || true",

src/dependency-builder/dependency-tree/index.js

@@ -66,6 +66,7 @@ module.exports._getDependencies = function (config) {
   let dependenciesRaw; // from some detectives it comes as an array, from some it is an object
   const precinctOptions = config.detectiveConfig;
   precinctOptions.includeCore = false;
+  delete precinct.ast;
 
   try {
     dependenciesRaw = precinct.paperwork(config.filename, precinctOptions);

src/dependency-builder/dependency-tree/index.spec.js

@@ -835,4 +835,29 @@ describe('dependencyTree', function () {
       expect(nonExistent[bazFile]).to.deep.equal(['non-exist-baz-pkg']);
     });
   });
+  describe('passing css files and then javascript files', () => {
+    beforeEach(() => {
+      mockfs({
+        [`${__dirname}/baz`]: {
+          'base.scss': 'li {} a {}', // don't change the content. it crash only with this for some reason
+          'index.jsx': "require('some-module');"
+        }
+      });
+    });
+    it('should not crash with "RangeError: Maximum call stack size exceeded" error', () => {
+      const directory = path.normalize(`${__dirname}/baz`);
+      const baseFile = path.normalize(`${directory}/base.scss`);
+      const indexFile = path.normalize(`${directory}/index.jsx`);
+      const config = {
+        directory
+      };
+
+      config.filename = baseFile;
+      dependencyTree(config);
+
+      config.filename = indexFile;
+      const dependencies = dependencyTree(config);
+      expect(dependencies).to.be.ok;
+    });
+  });
 });