resolve #731, support adding components as devDependencies

David First · David First · commit b904bd15061c · 2018-02-16T10:18:03.000-05:00
diff --git a/src/package-json/package-json.js b/src/package-json/package-json.js
@@ -82,8 +82,12 @@ export default class PackageJson {
     return JSON.stringify(this.toPlainObject(), null, 4);
   }
 
-  setDependencies(dependencies, bitDependencies: Object, registryPrefix: string) {
-    this.dependencies = Object.assign({}, dependencies, convertComponentsToValidPackageNames(registryPrefix, bitDependencies));
+  addDependencies(bitDependencies: Object, registryPrefix: string) {
+    this.dependencies = Object.assign({}, this.dependencies, convertComponentsToValidPackageNames(registryPrefix, bitDependencies));
+  }
+
+  addDevDependencies(bitDevDependencies: Object, registryPrefix: string) {
+    this.devDependencies = Object.assign({}, this.devDependencies, convertComponentsToValidPackageNames(registryPrefix, bitDevDependencies));
   }
 
   static hasExisting(componentRootFolder: string, throws?: boolean = false): boolean {

Original file line number	Diff line number	Diff line change
`@@ -82,8 +82,12 @@ export default class PackageJson {`
`82`	`82`	`return JSON.stringify(this.toPlainObject(), null, 4);`
`83`	`83`	`}`
`84`	`84`
`85`		`- setDependencies(dependencies, bitDependencies: Object, registryPrefix: string) {`
`86`		`- this.dependencies = Object.assign({}, dependencies, convertComponentsToValidPackageNames(registryPrefix, bitDependencies));`
	`85`	`+ addDependencies(bitDependencies: Object, registryPrefix: string) {`
	`86`	`+ this.dependencies = Object.assign({}, this.dependencies, convertComponentsToValidPackageNames(registryPrefix, bitDependencies));`
	`87`	`+ }`
	`88`	`+`
	`89`	`+ addDevDependencies(bitDevDependencies: Object, registryPrefix: string) {`
	`90`	`+ this.devDependencies = Object.assign({}, this.devDependencies, convertComponentsToValidPackageNames(registryPrefix, bitDevDependencies));`
`87`	`91`	`}`
`88`	`92`
`89`	`93`	`static hasExisting(componentRootFolder: string, throws?: boolean = false): boolean {`