ignore import/require from CDN (http/https) (#99)

* ignore dependencies from CDN (import from https/http)

* update CHANGELOG

* bump version

Author: davidfirst

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [unreleased]
 
+## [2.0.7] - 2019-05-17
+
+- ignore import/require from CDN (http/https)
+
 ## [2.0.6] - 2019-05-16
 
 - fix identification of link files to take into account not only the `import` statements but also `export`

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bit-javascript",
-  "version": "2.0.6",
+  "version": "2.0.7",
   "scripts": {
     "flow": "flow; test $? -eq 0 -o $? -eq 2",
     "lint": "eslint src && flow check || true",

src/dependency-builder/dependency-tree/index.js

@@ -94,6 +94,10 @@ module.exports._getDependencies = function (config) {
   return resolvedDependencies;
 
   function processDependency(dependency) {
+    if (isHttp(dependency)) {
+      debug(`skipping an http dependency: ${dependency}`);
+      return;
+    }
     const cabinetParams = {
       partial: dependency,
       filename: config.filename,
@@ -228,3 +232,10 @@ function traverse(config) {
     });
   }
 }
+
+/**
+ * whether the dependency is from CDN. (http/https)
+ */
+function isHttp(dependency) {
+  return Boolean(dependency.startsWith('http://') || dependency.startsWith('https://'));
+}

src/dependency-builder/dependency-tree/index.spec.js

@@ -866,7 +866,7 @@ describe('dependencyTree', function () {
     });
   });
   describe('files with dynamic import', () => {
-    it('should not', () => {
+    it('should not show missing dependencies', () => {
       mockfs({
         [`${__dirname}/dynamic`]: {
           'foo.js': 'const a = "./b"; import(a); require(a);'
@@ -884,4 +884,38 @@ describe('dependencyTree', function () {
       expect(visited[filename].missing).to.be.undefined;
     });
   });
+  describe('files with import from cdn (http, https)', () => {
+    it('should not show missing dependencies when importing from https', () => {
+      mockfs({
+        [`${__dirname}/cdn`]: {
+          'foo.js': 'import { a } from "https://unpkg.com";'
+        }
+      });
+      const directory = path.normalize(`${__dirname}/cdn`);
+      const filename = path.normalize(`${directory}/foo.js`);
+      const visited = {};
+      dependencyTree({
+        filename,
+        directory,
+        visited
+      });
+      expect(visited[filename].missing).to.be.undefined;
+    });
+    it('should not show missing dependencies when importing from http', () => {
+      mockfs({
+        [`${__dirname}/cdn`]: {
+          'bar.js': 'const b = require("http://pkg.com");'
+        }
+      });
+      const directory = path.normalize(`${__dirname}/cdn`);
+      const filename = path.normalize(`${directory}/bar.js`);
+      const visited = {};
+      dependencyTree({
+        filename,
+        directory,
+        visited
+      });
+      expect(visited[filename].missing).to.be.undefined;
+    });
+  });
 });