Declaration of Techouse\\SelectAutoComplete\\SelectAutoComplete::placeholder(string $placeholer) should be compatible with Laravel\\Nova\\Fields\\Field::placeholder($text)

[PaulLawton227]

select auto complete: v1.3.6
nova: 3.15.0
laravel: v8.15.0

This code below used to work on older versions, but we have recently upgraded to all the latest versions of laravel/nova/ etc.

I now get this error:

Declaration of Techouse\\SelectAutoComplete\\SelectAutoComplete::placeholder(string $placeholer) should be compatible with Laravel\\Nova\\Fields\\Field::placeholder($text)

when running the following code:

 Select::make(__('Customer'), 'customer_id')
                ->options(\App\Customer::all()->mapWithKeys(function ($customer) {
                    return [$customer->id => $customer->first_name . ' ' . $customer->last_name . " (" . $customer->email . ")"];
                }))
                ->displayUsingLabels()

[PaulLawton227]

changing the placeholder method to:

public function placeholder($text)
    {
        if ($text) {
            $this->placeholder = trim($text);

            return $this->withMeta([__FUNCTION__ => $this->placeholder]);
        }
    }

fixes the issue.

Can we get this updated in the main repo code?

[techouse]

changing the placeholder method to:

public function placeholder($text)
    {
        if ($text) {
            $this->placeholder = trim($text);

            return $this->withMeta([__FUNCTION__ => $this->placeholder]);
        }
    }

fixes the issue.

Can we get this updated in the main repo code?

Make a PR.