Skip to content

Commit bf34c06

Browse files
Fixing another insuffiently reliable unit test following student's question
1 parent 5d6aec1 commit bf34c06

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

test_doubles_fundamentals/src/test/java/com/techyourchance/testdoublesfundamentals/example4/LoginUseCaseSyncTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ public class LoginUseCaseSyncTest {
1919
public static final String USERNAME = "username";
2020
public static final String PASSWORD = "password";
2121
public static final String AUTH_TOKEN = "authToken";
22+
public static final String NON_INITIALIZED_AUTH_TOKEN = "noAuthToken";
2223

2324
LoginHttpEndpointSyncTd mLoginHttpEndpointSyncTd;
2425
AuthTokenCacheTd mAuthTokenCacheTd;
@@ -51,21 +52,21 @@ public void loginSync_success_authTokenCached() throws Exception {
5152
public void loginSync_generalError_authTokenNotCached() throws Exception {
5253
mLoginHttpEndpointSyncTd.mIsGeneralError = true;
5354
SUT.loginSync(USERNAME, PASSWORD);
54-
assertThat(mAuthTokenCacheTd.getAuthToken(), is(""));
55+
assertThat(mAuthTokenCacheTd.getAuthToken(), is(NON_INITIALIZED_AUTH_TOKEN));
5556
}
5657

5758
@Test
5859
public void loginSync_authError_authTokenNotCached() throws Exception {
5960
mLoginHttpEndpointSyncTd.mIsAuthError = true;
6061
SUT.loginSync(USERNAME, PASSWORD);
61-
assertThat(mAuthTokenCacheTd.getAuthToken(), is(""));
62+
assertThat(mAuthTokenCacheTd.getAuthToken(), is(NON_INITIALIZED_AUTH_TOKEN));
6263
}
6364

6465
@Test
6566
public void loginSync_serverError_authTokenNotCached() throws Exception {
6667
mLoginHttpEndpointSyncTd.mIsServerError = true;
6768
SUT.loginSync(USERNAME, PASSWORD);
68-
assertThat(mAuthTokenCacheTd.getAuthToken(), is(""));
69+
assertThat(mAuthTokenCacheTd.getAuthToken(), is(NON_INITIALIZED_AUTH_TOKEN));
6970
}
7071

7172
@Test
@@ -160,7 +161,7 @@ public EndpointResult loginSync(String username, String password) throws Network
160161

161162
private static class AuthTokenCacheTd implements AuthTokenCache {
162163

163-
String mAuthToken = "";
164+
String mAuthToken = NON_INITIALIZED_AUTH_TOKEN;
164165

165166
@Override
166167
public void cacheAuthToken(String authToken) {

0 commit comments

Comments
 (0)