Skip to content

Commit de2a88a

Browse files
authored
Enable reading replicationEnabled (#678)
<!-- Describe what has changed in this PR --> **What changed?** Enable reading of new field added in AddOrUpdateRemoteClusterResponse as these apparently aren't sharing/reusing a common proto for reading/writing <!-- Tell your future self why have you made these changes --> **Why?** Enabling reads from cli <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** na <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#8744 cli PR - temporalio/cli#881
1 parent 31333b1 commit de2a88a

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

buf.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ breaking:
1616
- temporal/api/enums/v1/failed_cause.proto
1717
# TODO: remove this once the changes with WorkflowExecutionExtendedInfo.pause_info is merged
1818
- temporal/api/workflow/v1/message.proto
19-
# TODO: remove this once is_replication_enabled -> enable_replication rename is merged
20-
- temporal/api/operatorservice/v1/request_response.proto
2119
lint:
2220
use:
2321
- DEFAULT

openapi/openapiv2.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10642,6 +10642,10 @@
1064210642
"isConnectionEnabled": {
1064310643
"type": "boolean",
1064410644
"description": "A flag to indicate if a connection is active."
10645+
},
10646+
"isReplicationEnabled": {
10647+
"type": "boolean",
10648+
"description": "A flag to indicate if replication is enabled."
1064510649
}
1064610650
}
1064710651
},

temporal/api/operatorservice/v1/request_response.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ message ClusterMetadata {
109109
int32 history_shard_count = 5;
110110
// A flag to indicate if a connection is active.
111111
bool is_connection_enabled = 6;
112+
// A flag to indicate if replication is enabled.
113+
bool is_replication_enabled = 8;
112114
}
113115

114116
message GetNexusEndpointRequest {

0 commit comments

Comments
 (0)