From 6e8b13da3cc55f8773b2451cc661a3518371e2f8 Mon Sep 17 00:00:00 2001
From: Ilya Priven <ip@rutterapi.com>
Date: Fri, 13 Sep 2024 15:43:29 +0100
Subject: [PATCH] *ActivityOptions: make either timeout required

---
 packages/common/src/activity-options.ts | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/packages/common/src/activity-options.ts b/packages/common/src/activity-options.ts
index 3c02f05ae..cc7f9d126 100644
--- a/packages/common/src/activity-options.ts
+++ b/packages/common/src/activity-options.ts
@@ -18,7 +18,7 @@ checkExtends<ActivityCancellationType, coresdk.workflow_commands.ActivityCancell
 /**
  * Options for remote activity invocation
  */
-export interface ActivityOptions {
+export type ActivityOptions = {
   /**
    * Identifier to use for tracking the activity in Workflow history.
    * The `activityId` can be accessed by the activity function.
@@ -111,12 +111,20 @@ export interface ActivityOptions {
    * @experimental
    */
   versioningIntent?: VersioningIntent;
-}
+} & (
+  {
+    scheduleToCloseTimeout: Duration;
+  } |
+  {
+    startToCloseTimeout: Duration;
+  }
+);
+
 
 /**
  * Options for local activity invocation
  */
-export interface LocalActivityOptions {
+export type LocalActivityOptions  = {
   /**
    * RetryPolicy that defines how an activity is retried in case of failure. If this is not set, then the SDK-defined default activity retry policy will be used.
    * Note that local activities are always executed at least once, even if maximum attempts is set to 1 due to Workflow task retries.
@@ -175,4 +183,11 @@ export interface LocalActivityOptions {
    * - `ABANDON` - Do not request cancellation of the activity and immediately report cancellation to the workflow.
    */
   cancellationType?: coresdk.workflow_commands.ActivityCancellationType;
-}
+} & (
+  {
+    scheduleToCloseTimeout: Duration;
+  } |
+  {
+    startToCloseTimeout: Duration;
+  }
+  );