Enable Worker heartbeating, plumb plugin names to core, update Core to 45b1d7e #1818
+131
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
force-pushed
the
worker-heartbeat
branch
from
1557d50 to
de87933
Compare
yuandrew
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chris-olszewski
requested changes
Dec 1, 2025
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Only required change is fixing up tests. Rest are light suggestions or questions.
packages/core-bridge/src/worker.rs
Outdated
| } | ||
| } | ||
| CompleteWfError::WorkflowNotEnabled => { | ||
| BridgeError::UnexpectedError(format!("{err}")) |
Member
There was a problem hiding this comment.
No strong opinions on this 🤷
Suggested change
| BridgeError::UnexpectedError(format!("{err}")) | |
| BridgeError::UnexpectedError(err.to_string()) |
| .into_iter() | ||
| .map(|name| PluginInfo { | ||
| name, | ||
| version: String::new(), |
Member
There was a problem hiding this comment.
Just for my own knowledge, is version from the past or not yet implemented?
Contributor
Author
There was a problem hiding this comment.
Good question, I don't know. haha. The API was originally implemented with version, but not sure what the intent was. Will follow up on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
WorkerTaskTypesbased on if workflows/activities/nexus handlers are registered to the workersdk-coreto45b1d7eWhy?
New feature!
Checklist
Closes [Feature Request] Enable Worker Heartbeating #1810
How was this tested:
Manually tested that heartbeats with a simple plugin from the worker and client both show up in plugins section of the worker heartbeat.
Also tested setting
workerHeartbeatInterval: nulldisables heartbeating for the workerNote
Adds configurable worker heartbeats, introduces explicit worker task type configuration, plumbs plugin names to Core, and updates bindings/tests accordingly.
worker_heartbeat_interval_millisfrom JS and setRuntimeOptions.heartbeat_interval.RuntimeOptions::try_intoreturns(telemetry, metrics, logging, worker_heartbeat_interval_millis).enable_non_local_activitieswithtask_types(enable_workflows,enable_local_activities,enable_remote_activities,enable_nexus).pluginsto Core asPluginInfo { name, version: "" }.WorkflowNotEnabled,ActivityNotEnabled,NexusNotEnabledtoUnexpectedError.newRuntimetakesruntimeOptions;RuntimeOptionsaddsworkerHeartbeatIntervalMillis.WorkerOptionsaddstaskTypesandplugins: string[].workerHeartbeatInterval(ms or null) and passed asworkerHeartbeatIntervalMillis.runtimeOptionsinstead oftelemetryOptionswhen creating the native runtime and metrics meter.taskTypesfrom registered workflows/activities/nexus; includepluginsnames in native options.Written by Cursor Bugbot for commit 826a363. This will update automatically on new commits. Configure here.