support nat zone (#1959)

* support nat zone

* support nat zone

Author: hellertang

.changelog/1959.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_nat_gateway: support set `zone`
+```

tencentcloud/resource_tc_clb_instance.go

@@ -795,8 +795,12 @@ func resourceTencentCloudClbInstanceUpdate(d *schema.ResourceData, meta interfac
 		request.SnatPro = &snatPro
 	}
 
-	if d.HasChange("snat_ips") {
-		return fmt.Errorf("`snat_ips`")
+	immutableArgs := []string{"snat_ips", "dynamic_vip"}
+
+	for _, v := range immutableArgs {
+		if d.HasChange(v) {
+			return fmt.Errorf("argument `%s` cannot be changed", v)
+		}
 	}
 
 	if changed {

tencentcloud/resource_tc_nat_gateway.go

@@ -4,15 +4,30 @@ Provides a resource to create a NAT gateway.
 Example Usage
 
 ```hcl
-resource "tencentcloud_nat_gateway" "foo" {
-  name             = "test_nat_gateway"
-  vpc_id           = "vpc-4xxr2cy7"
-  bandwidth        = 100
-  max_concurrent   = 1000000
-  assigned_eip_set = ["1.1.1.1"]
+data "tencentcloud_vpc_instances" "foo" {
+  name = "Default-VPC"
+}
+# Create EIP
+resource "tencentcloud_eip" "eip_dev_dnat" {
+  name = "terraform_nat_test"
+}
+resource "tencentcloud_eip" "new_eip" {
+  name = "terraform_nat_test"
+}
 
+resource "tencentcloud_nat_gateway" "my_nat" {
+  vpc_id         = data.tencentcloud_vpc_instances.foo.instance_list.0.vpc_id
+  name           = "new_name"
+  max_concurrent = 10000000
+  bandwidth      = 1000
+  zone           = "ap-guangzhou-3"
+
+  assigned_eip_set = [
+    tencentcloud_eip.eip_dev_dnat.public_ip,
+    tencentcloud_eip.new_eip.public_ip,
+  ]
   tags = {
-    test = "tf"
+    tf = "test"
   }
 }
 ```
@@ -86,6 +101,12 @@ func resourceTencentCloudNatGateway() *schema.Resource {
 				MaxItems:    10,
 				Description: "EIP IP address set bound to the gateway. The value of at least 1 and at most 10.",
 			},
+			"zone": {
+				Type:        schema.TypeString,
+				Optional:    true,
+				Computed:    true,
+				Description: "The availability zone, such as `ap-guangzhou-3`.",
+			},
 			"tags": {
 				Type:        schema.TypeMap,
 				Optional:    true,
@@ -124,6 +145,10 @@ func resourceTencentCloudNatGatewayCreate(d *schema.ResourceData, meta interface
 		}
 	}
 
+	if v, ok := d.GetOk("zone"); ok {
+		request.Zone = helper.String(v.(string))
+	}
+
 	if v := helper.GetTags(d, "tags"); len(v) > 0 {
 		for tagKey, tagValue := range v {
 			tag := vpc.Tag{
@@ -235,6 +260,7 @@ func resourceTencentCloudNatGatewayRead(d *schema.ResourceData, meta interface{}
 	_ = d.Set("bandwidth", *nat.InternetMaxBandwidthOut)
 	_ = d.Set("created_time", *nat.CreatedTime)
 	_ = d.Set("assigned_eip_set", flattenAddressList((*nat).PublicIpAddressSet))
+	_ = d.Set("zone", *nat.Zone)
 
 	tcClient := meta.(*TencentCloudClient).apiV3Conn
 	tagService := &TagService{client: tcClient}
@@ -254,6 +280,14 @@ func resourceTencentCloudNatGatewayUpdate(d *schema.ResourceData, meta interface
 	ctx := context.WithValue(context.TODO(), logIdKey, logId)
 	vpcService := VpcService{client: meta.(*TencentCloudClient).apiV3Conn}
 
+	immutableArgs := []string{"zone"}
+
+	for _, v := range immutableArgs {
+		if d.HasChange(v) {
+			return fmt.Errorf("argument `%s` cannot be changed", v)
+		}
+	}
+
 	d.Partial(true)
 	natGatewayId := d.Id()
 	request := vpc.NewModifyNatGatewayAttributeRequest()

website/docs/r/nat_gateway.html.markdown

@@ -14,15 +14,30 @@ Provides a resource to create a NAT gateway.
 ## Example Usage
 
 ```hcl
-resource "tencentcloud_nat_gateway" "foo" {
-  name             = "test_nat_gateway"
-  vpc_id           = "vpc-4xxr2cy7"
-  bandwidth        = 100
-  max_concurrent   = 1000000
-  assigned_eip_set = ["1.1.1.1"]
+data "tencentcloud_vpc_instances" "foo" {
+  name = "Default-VPC"
+}
+# Create EIP
+resource "tencentcloud_eip" "eip_dev_dnat" {
+  name = "terraform_nat_test"
+}
+resource "tencentcloud_eip" "new_eip" {
+  name = "terraform_nat_test"
+}
 
+resource "tencentcloud_nat_gateway" "my_nat" {
+  vpc_id         = data.tencentcloud_vpc_instances.foo.instance_list.0.vpc_id
+  name           = "new_name"
+  max_concurrent = 10000000
+  bandwidth      = 1000
+  zone           = "ap-guangzhou-3"
+
+  assigned_eip_set = [
+    tencentcloud_eip.eip_dev_dnat.public_ip,
+    tencentcloud_eip.new_eip.public_ip,
+  ]
   tags = {
-    test = "tf"
+    tf = "test"
   }
 }
 ```
@@ -37,6 +52,7 @@ The following arguments are supported:
 * `bandwidth` - (Optional, Int) The maximum public network output bandwidth of NAT gateway (unit: Mbps). Valid values: `20`, `50`, `100`, `200`, `500`, `1000`, `2000`, `5000`. Default is 100.
 * `max_concurrent` - (Optional, Int) The upper limit of concurrent connection of NAT gateway. Valid values: `1000000`, `3000000`, `10000000`. Default is `1000000`.
 * `tags` - (Optional, Map) The available tags within this NAT gateway.
+* `zone` - (Optional, String) The availability zone, such as `ap-guangzhou-3`.
 
 ## Attributes Reference