fixed the problem of mx parameter transmission when modifying dnspod … (#2413)

* fixed the problem of mx parameter transmission when modifying dnspod records

* add changelog 2413.txt

* add mx test

Author: bruceybian

.changelog/2413.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/tencentcloud_dnspod_record: Fix `mx` parameter passing problem.
+```

tencentcloud/resource_tc_dnspod_record.go

@@ -236,10 +236,8 @@ func resourceTencentCloudDnspodRecordUpdate(d *schema.ResourceData, meta interfa
 		status := d.Get("status").(string)
 		request.Status = &status
 	}
-	if d.HasChange("mx") {
-		if v, ok := d.GetOk("mx"); ok {
-			request.MX = helper.IntUint64(v.(int))
-		}
+	if v, ok := d.GetOk("mx"); ok {
+		request.MX = helper.IntUint64(v.(int))
 	}
 	if d.HasChange("ttl") {
 		ttl := d.Get("ttl").(int)

tencentcloud/resource_tc_dnspod_record_test.go

@@ -55,6 +55,51 @@ func TestAccTencentCloudDnspodRecordResource_basic(t *testing.T) {
 	})
 }
 
+func TestAccTencentCloudDnspodRecordResource_MX(t *testing.T) {
+	t.Parallel()
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheckCommon(t, ACCOUNT_TYPE_PREPAY) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckDnspodRecordDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccTencentCloudDnspodRecordMx,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckDnspodRecordExists("tencentcloud_dnspod_record.demo"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "domain", "iac-tf.cloud"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_type", "MX"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_line", "默认"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "value", "1.2.3.9."),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "sub_domain", "@"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "mx", "10"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "ttl", "86400"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "status", "ENABLE"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "remark", "terraform-test"),
+				),
+			},
+			{
+				Config: testAccTencentCloudDnspodRecordMxUpdate,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "domain", "iac-tf.cloud"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_type", "MX"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_line", "默认"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "value", "1.2.3.19."),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "sub_domain", "@"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "mx", "10"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "ttl", "86400"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "status", "ENABLE"),
+					resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "remark", "terraform-test"),
+				),
+			},
+			{
+				ResourceName:      "tencentcloud_dnspod_record.demo",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func testAccCheckDnspodRecordExists(n string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]
@@ -152,3 +197,30 @@ const testAccTencentCloudDnspodRecordRemarkUp = `
 	remark="terraform-test1"
 	}
 `
+
+const testAccTencentCloudDnspodRecordMx = `
+resource "tencentcloud_dnspod_record" "demo" {
+  domain      = "iac-tf.cloud"
+  record_type = "MX"
+  record_line = "默认"
+  value       = "1.2.3.9."
+  sub_domain  = "@"
+  mx          = 10
+  ttl         = 86400
+  status      = "ENABLE"
+  remark      = "terraform-test"
+}
+`
+const testAccTencentCloudDnspodRecordMxUpdate = `
+resource "tencentcloud_dnspod_record" "demo" {
+  domain      = "iac-tf.cloud"
+  record_type = "MX"
+  record_line = "默认"
+  value       = "1.2.3.19."
+  sub_domain  = "@"
+  mx          = 10
+  ttl         = 86400
+  status      = "ENABLE"
+  remark      = "terraform-test"
+}
+`