refactor: rewrite rules update

Author: Sherlock-Holo

tencentcloud/resource_tc_security_group_lite_rule.go

@@ -1,7 +1,7 @@
 /*
 Provide a resource to create security group some lite rules quickly.
 
--> **NOTE:** It can't be used with tencentcloud_security_group_rule, and don't create multi tencentcloud_security_group_rule resources, otherwise it may cause problems.
+-> **NOTE:** It can't be used with tencentcloud_security_group_rule, and don't create multiple tencentcloud_security_group_rule resources, otherwise it may cause problems.
 
 Example Usage
 
@@ -113,7 +113,7 @@ func resourceTencentCloudSecurityGroupLiteRuleCreate(d *schema.ResourceData, m i
 		}
 	}
 
-	if err := service.AttachLiteRulesToSecurityGroup(ctx, sgId, ingress, egress, updateLiteRule, updateLiteRule); err != nil {
+	if err := service.AttachLiteRulesToSecurityGroup(ctx, sgId, ingress, egress); err != nil {
 		return err
 	}
 
@@ -170,16 +170,14 @@ func resourceTencentCloudSecurityGroupLiteRuleUpdate(d *schema.ResourceData, m i
 	service := VpcService{client: m.(*TencentCloudClient).apiV3Conn}
 
 	var (
-		ingress           []VpcSecurityGroupLiteRule
-		egress            []VpcSecurityGroupLiteRule
-		updateIngressKind = noModifyLiteRule
-		updateEgressKind  = noModifyLiteRule
+		ingress       []VpcSecurityGroupLiteRule
+		egress        []VpcSecurityGroupLiteRule
+		deleteIngress bool
+		deleteEgress  bool
 	)
 
 	if d.HasChange("ingress") {
 		if raw, ok := d.GetOk("ingress"); ok {
-			updateIngressKind = updateLiteRule
-
 			ingressStrs := helper.InterfacesStrings(raw.([]interface{}))
 			for _, ingressStr := range ingressStrs {
 				liteRule, err := parseRule(ingressStr)
@@ -189,8 +187,6 @@ func resourceTencentCloudSecurityGroupLiteRuleUpdate(d *schema.ResourceData, m i
 				ingress = append(ingress, liteRule)
 			}
 		} else {
-			updateIngressKind = deleteLiteRule
-
 			old, _ := d.GetChange("ingress")
 			ingressStrs := helper.InterfacesStrings(old.([]interface{}))
 			for _, ingressStr := range ingressStrs {
@@ -200,13 +196,13 @@ func resourceTencentCloudSecurityGroupLiteRuleUpdate(d *schema.ResourceData, m i
 				}
 				ingress = append(ingress, liteRule)
 			}
+
+			deleteIngress = true
 		}
 	}
 
 	if d.HasChange("egress") {
 		if raw, ok := d.GetOk("egress"); ok {
-			updateEgressKind = updateLiteRule
-
 			egressStrs := helper.InterfacesStrings(raw.([]interface{}))
 			for _, egressStr := range egressStrs {
 				liteRule, err := parseRule(egressStr)
@@ -216,8 +212,6 @@ func resourceTencentCloudSecurityGroupLiteRuleUpdate(d *schema.ResourceData, m i
 				egress = append(egress, liteRule)
 			}
 		} else {
-			updateEgressKind = deleteLiteRule
-
 			old, _ := d.GetChange("egress")
 			egressStrs := helper.InterfacesStrings(old.([]interface{}))
 			for _, egressStr := range egressStrs {
@@ -227,19 +221,52 @@ func resourceTencentCloudSecurityGroupLiteRuleUpdate(d *schema.ResourceData, m i
 				}
 				egress = append(egress, liteRule)
 			}
+
+			deleteEgress = true
 		}
 	}
 
-	if updateIngressKind == deleteLiteRule && updateEgressKind == deleteLiteRule {
+	d.Partial(true)
+
+	if deleteIngress && deleteEgress {
 		if err := service.DetachAllLiteRulesFromSecurityGroup(ctx, id); err != nil {
 			return err
 		}
-	} else {
-		if err := service.modifyLiteRulesInSecurityGroup(ctx, id, ingress, egress, updateIngressKind, updateEgressKind); err != nil {
+
+		d.Partial(false)
+
+		return resourceTencentCloudSecurityGroupLiteRuleRead(d, m)
+	}
+
+	if deleteIngress {
+		if err := service.DeleteLiteRules(ctx, id, ingress, true); err != nil {
+			return err
+		}
+
+		d.SetPartial("ingress")
+
+		ingress = nil
+	}
+
+	if deleteEgress {
+		if err := service.DeleteLiteRules(ctx, id, egress, false); err != nil {
+			return err
+		}
+
+		d.SetPartial("egress")
+
+		egress = nil
+	}
+
+	// if both len == 0, means both rules are deleted
+	if len(ingress) > 0 || len(egress) > 0 {
+		if err := service.modifyLiteRulesInSecurityGroup(ctx, id, ingress, egress); err != nil {
 			return err
 		}
 	}
 
+	d.Partial(false)
+
 	return resourceTencentCloudSecurityGroupLiteRuleRead(d, m)
 }