From 95f9510ca3ca8e55fcac78450029d2584c7d6d21 Mon Sep 17 00:00:00 2001 From: Anmol Mago Date: Mon, 13 Aug 2018 15:06:01 -0700 Subject: [PATCH] Fix tensorflow version check The current version, a string "1.11.0-dev20180813" is greater than the minimum version of "1.4.0-dev20171024". However, using string comparisons this check fails due to 1 being less than 4. --- nmt/utils/misc_utils.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nmt/utils/misc_utils.py b/nmt/utils/misc_utils.py index a680a5cf2..080a7f215 100644 --- a/nmt/utils/misc_utils.py +++ b/nmt/utils/misc_utils.py @@ -25,12 +25,13 @@ import time import numpy as np +from distutils.version import LooseVersion, StrictVersion import tensorflow as tf def check_tensorflow_version(): min_tf_version = "1.4.0-dev20171024" - if tf.__version__ < min_tf_version: + if LooseVersion(tf.__version__) < LooseVersion(min_tf_version): raise EnvironmentError("Tensorflow version must >= %s" % min_tf_version)