Replace only packages marked as deps during a release (#6245)

* In release, replace only packages marked as deps

\#6209 made the release script overwrite every dependency in the set of packages being published. This causes tfjs-core's verdaccio tests to fail because tfjs-core has a devDependency on tfjs-backend-cpu, but core needs to be published before cpu. This PR reverts to the original behavior of overwriting dependency versions in the package.json only if they are listed in a given release phase's dependencies.

* Remove update-dependency.ts from e2e

Author: mattsoulanille

e2e/package.json

@@ -64,7 +64,6 @@
     "test": "./scripts/test.sh",
     "coverage": "KARMA_COVERAGE=1 ./scripts/test.sh",
     "test-ci": "./scripts/test-ci.sh",
-    "update-dependency": "ts-node ./scripts/update-dependency.ts",
     "deploy-benchmarks": "./scripts/deploy-benchmarks.sh",
     "deploy-benchmarks-dev": "./scripts/deploy-benchmarks.sh --dev",
     "deploy-benchmarks-staging": "./scripts/deploy-benchmarks.sh --staging"

e2e/scripts/publish-tfjs-ci.sh

@@ -89,8 +89,3 @@ do
 
   cd ..
 done
-
-# Update e2e's package.json's all tfjs related packages to locally published
-# version.
-cd e2e
-npx ts-node ./scripts/update-dependency.ts --version=$RELEASE_VERSION

e2e/scripts/update-dependency.ts

@@ -103,7 +103,7 @@ async function main() {
       const newVersion = versions.get(packageName);
       pkg = `${pkg}`.replace(
         `"version": "${parsedPkg.version}"`, `"version": "${newVersion}"`);
-      pkg = updateTFJSDependencyVersions(pkg, versions);
+      pkg = updateTFJSDependencyVersions(pkg, versions, phase.deps || []);
 
       fs.writeFileSync(packageJsonPath, pkg);
 

scripts/release-tfjs.ts

@@ -295,12 +295,17 @@ export async function updateDependency(
 // than `updateDependency`, it does not rely on published versions, instead it
 // uses a map from packageName to newVersion to update the versions.
 export function updateTFJSDependencyVersions(
-  pkg: string, versions: Map<string, string>): string {
+  pkg: string, versions: Map<string, string>,
+  depsToReplace = [...versions.keys()]): string {
 
   console.log(chalk.magenta.bold(`~~~ Update dependency versions ~~~`));
 
   const parsedPkg = JSON.parse(`${pkg}`);JSON.parse(pkg);
-  for (const [dep, newVersion] of versions) {
+  for (const dep of depsToReplace) {
+    const newVersion = versions.get(dep);
+    if (!newVersion) {
+      throw new Error(`No new version found for ${dep}`);
+    }
     // Get the current dependency package version.
     let version = '';
     const depNpmName = `@tensorflow/${dep}`;