feat(helm>=3)!: Update 'set' syntax in helm_resource to support v3 (#220)

Co-authored-by: Andrew Peabody <andrewpeabody@google.com>

Author: yannickjones

examples/gh-runner-gke-dind-rootless/providers.tf

@@ -28,11 +28,11 @@ provider "kubernetes" {
 }
 
 provider "helm" {
-  kubernetes {
+  kubernetes = {
     host                   = "https://${module.runner-gke.kubernetes_endpoint}"
     token                  = data.google_client_config.default.access_token
     cluster_ca_certificate = base64decode(module.runner-gke.ca_certificate)
-    exec {
+    exec = {
       api_version = "client.authentication.k8s.io/v1beta1"
       command     = "gke-gcloud-auth-plugin"
     }

examples/gh-runner-gke-dind/providers.tf

@@ -28,11 +28,11 @@ provider "kubernetes" {
 }
 
 provider "helm" {
-  kubernetes {
+  kubernetes = {
     host                   = "https://${module.runner-gke.kubernetes_endpoint}"
     token                  = data.google_client_config.default.access_token
     cluster_ca_certificate = base64decode(module.runner-gke.ca_certificate)
-    exec {
+    exec = {
       api_version = "client.authentication.k8s.io/v1beta1"
       command     = "gke-gcloud-auth-plugin"
     }

examples/gh-runner-gke-simple/providers.tf

@@ -28,11 +28,11 @@ provider "kubernetes" {
 }
 
 provider "helm" {
-  kubernetes {
+  kubernetes = {
     host                   = "https://${module.runner-gke.kubernetes_endpoint}"
     token                  = data.google_client_config.default.access_token
     cluster_ca_certificate = base64decode(module.runner-gke.ca_certificate)
-    exec {
+    exec = {
       api_version = "client.authentication.k8s.io/v1beta1"
       command     = "gke-gcloud-auth-plugin"
     }

modules/gh-runner-gke/main.tf

@@ -127,23 +127,24 @@ resource "helm_release" "arc_runners_set" {
   chart     = "oci://ghcr.io/actions/actions-runner-controller-charts/gha-runner-scale-set"
   version   = var.arc_runners_version
 
-  set {
-    name  = "githubConfigSecret"
-    value = kubernetes_secret.gh_app_pre_defined_secret.metadata[0].name
-  }
-
-  set {
-    name  = "githubConfigUrl"
-    value = var.gh_config_url
-  }
-
-  dynamic "set" {
-    for_each = var.arc_container_mode == "" ? [] : [1]
-    content {
-      name  = "containerMode.type"
-      value = var.arc_container_mode
-    }
-  }
+  set = concat(
+    [
+      {
+        name  = "githubConfigSecret"
+        value = kubernetes_secret.gh_app_pre_defined_secret.metadata[0].name
+      },
+      {
+        name  = "githubConfigUrl"
+        value = var.gh_config_url
+      }
+    ],
+    var.arc_container_mode == "" ? [] : [
+      {
+        name  = "containerMode.type"
+        value = var.arc_container_mode
+      }
+    ]
+  )
 
   values = var.arc_runners_values
 }

modules/gh-runner-gke/versions.tf

@@ -35,7 +35,7 @@ terraform {
 
     helm = {
       source  = "hashicorp/helm"
-      version = "~> 2.0"
+      version = "~> 3.0"
     }
   }