Skip to content

Update TP: Java: Multiple patterns / confounding factor / generics #18

@vlkl-sap

Description

@vlkl-sap

Testability pattern

Consider 103_arrays_aslist:

String s = request.getParameter("t1");
String [] stringArr = {s};
List l = Arrays.asList(stringArr);
response.getWriter().write(l.get(0).toString());

Problem statement

Some tools are apparently tripping up on the fact that l is declared as a List rather than a List<String>, i.e., they fail to track the full type of the list object that l points to. This failure has nothing to do with the intent of the pattern and should be tested for in a separate pattern, but not here.

In other tools, this failure could be masked, if they assume that toString() propagates taint for all objects.

There are also other patterns/instances that have the same problem, but I did not bother to review them all. Candidates:
102_collection_taint_propagation, 24_arraylist

Proposed changes

Other

Metadata

Metadata

Assignees

No one assigned

    Labels

    ACK_WAITINGissue to be reviewed and confirmedUPDATE_TPissue is about updating a testability pattern

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions