Fixes #34714 - Refactor handling of External IPAM response #9174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Apr 5, 2022
grizzthedj
force-pushed
the
external-ipam-fixes
branch
from
a7ab162 to
5799b43
Compare
ekohl
approved these changes
Apr 5, 2022
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
👍 when CI is green. Right now it's still running and I've been known to forget to check back in. If this is green, any other maintainer should feel free to merge this.
evgeni
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ekohl This is a simple refactoring of the External IPAM API response handling for the get_next_ip call.
This fix is required for the merging of External IPAM features into Smart Proxy Core.
PR: theforeman/smart-proxy#810
Once the above Smart Proxy PR is merged, this Foreman change will be required for the integration to work.