Skip to content

Commit 88cc644

Browse files
ekurdybxekurdybx
committed
check-alsabat: add option to test with pipewire
1 parent 7ed2f47 commit 88cc644

File tree

3 files changed

+163
-47
lines changed

3 files changed

+163
-47
lines changed

‎case-lib/lib.sh‎

Lines changed: 63 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -594,6 +594,7 @@ func_lib_enable_pipewire()
594594
systemctl --user start wireplumber.service
595595

596596
systemctl --user daemon-reload
597+
sleep 3
597598

598599
systemctl is-active --user --quiet pipewire{,-pulse}.{socket,service} && dlogi "Pipewire started"
599600
systemctl is-active --user --quiet wireplumber.service && dlogi "Wireplumber started"
@@ -615,6 +616,7 @@ func_lib_disable_pipewire()
615616

616617
sudo systemctl --global mask wireplumber.service
617618
sudo systemctl --global mask pipewire{,-pulse}.{socket,service}
619+
sleep 1
618620

619621
if systemctl is-active --user --quiet wireplumber.service; then dlogi "Wireplumber not stopped"; else dlogi "Wireplumber stopped"; fi
620622
if systemctl is-active --user --quiet pipewire{,-pulse}.{socket,service}; then dlogi "Pipewire not stopped"; else dlogi "Pipewire stopped"; fi
@@ -957,15 +959,9 @@ aplay_opts()
957959
# shellcheck disable=SC2086
958960
tinyplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS -D "$card_nr" -d "$dev_nr" -i wav noise.wav
959961
elif [[ "$SOF_ALSA_TOOL" = "alsa" ]]; then
960-
if [[ "$SOF_TEST_PIPEWIRE" == true ]]; then
961-
dlogc "timeout -k $duration $duration aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS $*" # option -d doesn't work with pipewire so we need timeout
962-
# shellcheck disable=SC2086
963-
timeout -k "$duration" "$duration" aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
964-
else
965-
dlogc "aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS $*"
966-
# shellcheck disable=SC2086
967-
aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
968-
fi
962+
dlogc "aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS $*"
963+
# shellcheck disable=SC2086
964+
aplay $SOF_ALSA_OPTS $SOF_APLAY_OPTS "$@"
969965
else
970966
die "Unknown ALSA tool: ${SOF_ALSA_TOOL}"
971967
fi
@@ -982,20 +978,33 @@ arecord_opts()
982978
# shellcheck disable=SC2086
983979
tinycap $SOF_ALSA_OPTS $SOF_ARECORD_OPTS "$file" -D "$card_nr" -d "$dev_nr" -c "$channel" -t "$duration" -r "$rate" -b "$format"
984980
elif [[ "$SOF_ALSA_TOOL" = "alsa" ]]; then
985-
if [[ "$SOF_TEST_PIPEWIRE" == true ]]; then
986-
dlogc "timeout -k $duration $duration arecord $SOF_ALSA_OPTS $SOF_ARECORD_OPTS $*" # option -d doesn't work with pipewire so we need timeout
987-
# shellcheck disable=SC2086
988-
timeout -k "$duration" "$duration" arecord $SOF_ALSA_OPTS $SOF_ARECORD_OPTS "$@"
989-
else
990-
dlogc "arecord $SOF_ALSA_OPTS $SOF_ARECORD_OPTS $*"
991-
# shellcheck disable=SC2086
992-
arecord $SOF_ALSA_OPTS $SOF_ARECORD_OPTS "$@"
993-
fi
981+
dlogc "arecord $SOF_ALSA_OPTS $SOF_ARECORD_OPTS $*"
982+
# shellcheck disable=SC2086
983+
arecord $SOF_ALSA_OPTS $SOF_ARECORD_OPTS "$@"
994984
else
995985
die "Unknown ALSA tool: ${SOF_ALSA_TOOL}"
996986
fi
997987
}
998988

989+
# Get the ID of the first source of a given type, e.g. "Microphone" or "Audio codec". Print an empty line if ID not found.
990+
get_id_of_pipewire_source()
991+
{
992+
# $ wpctl status returns list of all endpoints managed by wireplumber. We use grep to get only lines after "Sources".
993+
# Then we filter by given sink/source type, which returns something like this:
994+
# │ * 48. sof-soundwire Microphone [vol: 0.40] (or without the * when it's not the current default)
995+
# We filter out everything but ID, and only take the first line of the output (if there's more that one object of that type we ignore the rest)
996+
997+
local object_name="$1"
998+
object_id=$(wpctl status | grep "Sources" -A 10 | awk -v name="$object_name" 'tolower($0) ~ tolower(name) { sub(/\*/,""); sub(/\./,"",$2); print $2; exit }')
999+
1000+
# Check if object_id is a number
1001+
re='^[0-9]+$'
1002+
if [[ "$object_id" =~ $re ]] ; then
1003+
printf '%s' "$object_id"
1004+
fi
1005+
1006+
}
1007+
9991008
# Get the ID of the first sink/source of a given type, e.g. "Speaker" or "Headphones". Print an empty line if ID not found.
10001009
get_id_of_pipewire_endpoint()
10011010
{
@@ -1014,6 +1023,42 @@ get_id_of_pipewire_endpoint()
10141023

10151024
}
10161025

1026+
# Get pipewire sink name for given alsa pcm
1027+
# Arguments: 1-alsa pcm, ex. hw:0,0
1028+
set_default_pipewire_sink_for_alsa_pcm()
1029+
{
1030+
card_id=$(echo "$1" | awk -F'[:,]' '{print $2}')
1031+
dev_id=$(echo "$1" | awk -F'[:,]' '{print $3}')
1032+
dlogi "card: $card_id, device: $dev_id"
1033+
1034+
sink_name=$(pactl list sinks \
1035+
| grep -B 20 "alsa.device = \"$dev_id\"" \
1036+
| grep -B 16 "alsa.card = \"$card_id\"" \
1037+
| grep "Name: alsa_output" \
1038+
| cut -d' ' -f2-)
1039+
1040+
dlogi "Setting default sink set to $sink_name"
1041+
pactl set-default-sink "$sink_name"
1042+
}
1043+
1044+
# Get pipewire source name for given alsa pcm
1045+
# Arguments: 1-alsa pcm, ex. hw:0,0
1046+
set_default_pipewire_source_for_alsa_pcm()
1047+
{
1048+
card_id=$(echo "$1" | awk -F'[:,]' '{print $2}')
1049+
dev_id=$(echo "$1" | awk -F'[:,]' '{print $3}')
1050+
dlogi "card: $card_id, device: $dev_id"
1051+
1052+
sink_name=$(pactl list sources \
1053+
| grep -B 20 "alsa.device = \"$dev_id\"" \
1054+
| grep -B 16 "alsa.card = \"$card_id\"" \
1055+
| grep "Name: alsa_input" \
1056+
| cut -d' ' -f2-)
1057+
1058+
dlogi "Setting default source set to $sink_name"
1059+
pactl set-default-source "$sink_name"
1060+
}
1061+
10171062
die()
10181063
{
10191064
dloge "$@"

‎test-case/check-alsabat.sh‎

Lines changed: 98 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -100,32 +100,103 @@ function __upload_wav_file
100100
done
101101
}
102102

103-
# check the PCMs before alsabat test
104-
dlogi "check the PCMs before alsabat test"
105-
aplay "-Dplug${pcm_p}" -d 1 /dev/zero -q || die "Failed to play on PCM: ${pcm_p}"
106-
arecord "-Dplug${pcm_c}" -d 1 /dev/null -q || die "Failed to capture on PCM: ${pcm_c}"
107-
108-
# alsabat test
109-
# BT offload PCMs also support mono playback.
110-
dlogc "alsabat -P$pcm_p --standalone -n $frames -r $rate -c $channel_p -f $format -F $frequency -k $sigmak"
111-
alsabat "-P${pcm_p}" --standalone -n "${frames}" -c "${channel_p}" -r "${rate}" -f "${format}" -F "${frequency}" -k "${sigmak}" & playPID=$!
112-
113-
# playback may have low latency, add one second delay to aviod recording zero at beginning.
114-
sleep 1
115-
116-
# Select the first card
117-
first_card_name=$(aplay -l | awk '/^card ([0-9]+)/ {print $3; exit}')
118-
# dump amixer contents always.
119-
# Good case amixer settings is for reference, bad case for debugging.
120-
amixer -c "${first_card_name}" contents > "$LOG_ROOT"/amixer_settings.txt
121-
122-
# We use different USB sound cards in CI, part of them only support 1 channel for capture,
123-
# so make the channel as an option and config it in alsabat-playback.csv
124-
dlogc "alsabat -C$pcm_c -c $channel_c -r $rate -f $format -F $frequency -k $sigmak"
125-
alsabat "-C${pcm_c}" -c "${channel_c}" -r "${rate}" -f "${format}" -F "${frequency}" -k "${sigmak}" || {
126-
# upload failed wav file
127-
__upload_wav_file
128-
exit 1
103+
# Set default pipewire sink and source
104+
set_pcms_in_pipewire()
105+
{
106+
set_default_pipewire_sink_for_alsa_pcm "$pcm_p"
107+
set_default_pipewire_source_for_alsa_pcm "$pcm_c"
108+
}
109+
110+
check_the_pcms()
111+
{
112+
aplay "-Dplug${pcm_p}" -d 1 /dev/zero -q || die "Failed to play on PCM: ${pcm_p}"
113+
arecord "-Dplug${pcm_c}" -d 1 /dev/null -q || die "Failed to capture on PCM: ${pcm_c}"
114+
}
115+
116+
check_the_pcms_with_pipewire()
117+
{
118+
aplay -D pipewire -d 1 /dev/zero -q || die "Failed to play on pipewire"
119+
arecord -D pipewire -d 1 /dev/null -q || die "Failed to capture on pipewire"
120+
}
121+
122+
run_test_on_pipewire()
123+
{
124+
# Set correct sink and source in pipewire
125+
set_pcms_in_pipewire
126+
127+
# check the PCMs before alsabat test
128+
check_the_pcms_with_pipewire
129+
130+
# alsabat tests
131+
dlogc "alsabat -P pipewire --standalone -n $frames -r $rate -c $channel_p -f $format -F $frequency -k $sigmak"
132+
alsabat -P pipewire --standalone -n "${frames}" -c "${channel_p}" -r "${rate}" -f "${format}" -F "${frequency}" -k "${sigmak}" & playPID=$!
133+
134+
dlogc "alsabat -C pipewire --standalone -n $frames -c $channel_p -r $rate -f $format -F $frequency -k $sigmak"
135+
alsabat -C pipewire --standalone -n "${frames}" -c "${channel_p}" -r "${rate}" -f "${format}" -F "${frequency}" -k "${sigmak}" || {
136+
# upload failed wav file
137+
__upload_wav_file
138+
exit 1
139+
}
140+
}
141+
142+
run_test_on_alsa_direct_mode()
143+
{
144+
# check the PCMs before alsabat test
145+
check_the_pcms
146+
147+
# alsabat test
148+
# BT offload PCMs also support mono playback.
149+
dlogc "alsabat -P$pcm_p --standalone -n $frames -r $rate -c $channel_p -f $format -F $frequency -k $sigmak"
150+
alsabat "-P${pcm_p}" --standalone -n "${frames}" -c "${channel_p}" -r "${rate}" -f "${format}" -F "${frequency}" -k "${sigmak}" & playPID=$!
151+
152+
# playback may have low latency, add one second delay to aviod recording zero at beginning.
153+
sleep 1
154+
155+
# Select the first card
156+
first_card_name=$(aplay -l | awk '/^card ([0-9]+)/ {print $3; exit}')
157+
# dump amixer contents always.
158+
# Good case amixer settings is for reference, bad case for debugging.
159+
amixer -c "${first_card_name}" contents > "$LOG_ROOT"/amixer_settings.txt
160+
161+
# We use different USB sound cards in CI, part of them only support 1 channel for capture,
162+
# so make the channel as an option and config it in alsabat-playback.csv
163+
dlogc "alsabat -C$pcm_c -c $channel_c -r $rate -f $format -F $frequency -k $sigmak"
164+
alsabat "-C${pcm_c}" -c "${channel_c}" -r "${rate}" -f "${format}" -F "${frequency}" -k "${sigmak}" || {
165+
# upload failed wav file
166+
__upload_wav_file
167+
exit 1
168+
}
169+
170+
wait $playPID
171+
}
172+
173+
main()
174+
{
175+
start_test
176+
177+
if [ "$SOF_TEST_PIPEWIRE" == true ] && [[ "$TPLG" == *rt712* ]]; then
178+
skip_test "Skipping: test not supported for RT712 configuration"
179+
fi
180+
181+
if [ "$pcm_p" = "" ]||[ "$pcm_c" = "" ];
182+
then
183+
dloge "No playback or capture PCM is specified. Skip the alsabat test"
184+
exit 2
185+
fi
186+
187+
check_locale_for_alsabat
188+
189+
logger_disabled || func_lib_start_log_collect
190+
191+
set_alsa
192+
193+
if [ "$SOF_TEST_PIPEWIRE" == true ]; then
194+
run_test_on_pipewire
195+
else
196+
run_test_on_alsa_direct_mode
197+
fi
129198
}
130199

131-
wait $playPID
200+
{
201+
main "$@"; exit "$?"
202+
}

‎test-case/check-performance.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ run_aplays()
5959
fi
6060
dlogi "Setting default sink to $sink_id: $sink_type"
6161
wpctl set-default "$sink_id"
62-
aplay_opts -D pipewire /dev/zero -q &
62+
aplay_opts -D pipewire /dev/zero -d "$duration" -q &
6363
aplay_num=$((aplay_num+1))
6464
done
6565
}
@@ -78,7 +78,7 @@ run_arecords()
7878
fi
7979
dlogi "Setting default source to $source_id: $source_type"
8080
wpctl set-default "$source_id"
81-
arecord_opts -D pipewire /dev/null -q &
81+
arecord_opts -D pipewire /dev/null -d "$duration" -q &
8282
arecord_num=$((arecord_num+1))
8383
done
8484
}

0 commit comments

Comments
 (0)