Skip to content

Commit 87f5e3e

Browse files
committed
module_adapter: modules: Remove unused sys_service pointer
The unused sys_service field has been removed from the processing_module structure. It was never initialized anywhere, and its value was passed as a parameter to the native_system_agent_start function which did not use it. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
1 parent c951d57 commit 87f5e3e

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

src/audio/module_adapter/library/native_system_agent.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@ typedef void* (*native_create_instance_f)(void *mod_cfg, void *parent_ppl,
1919

2020
struct native_system_agent native_sys_agent;
2121

22-
void *native_system_agent_start(uint32_t *sys_service,
23-
uint32_t entry_point, uint32_t module_id,
24-
uint32_t instance_id, uint32_t core_id, uint32_t log_handle,
25-
void *mod_cfg)
22+
void *native_system_agent_start(uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
23+
uint32_t core_id, uint32_t log_handle, void *mod_cfg)
2624
{
2725
native_sys_agent.module_id = module_id;
2826
native_sys_agent.instance_id = instance_id;

src/include/module/module/base.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,6 @@ struct processing_module {
180180
*/
181181
bool stream_copy_single_to_single;
182182

183-
/* pointer to system services for loadable modules */
184-
uint32_t *sys_service;
185-
186183
/* total processed data after stream started */
187184
uint64_t total_data_consumed;
188185
uint64_t total_data_produced;

src/include/sof/audio/module_adapter/library/native_system_agent.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ struct native_system_agent {
2020
uint32_t module_size;
2121
};
2222

23-
void *native_system_agent_start(uint32_t *sys_service,
24-
uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
23+
void *native_system_agent_start(uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
2524
uint32_t core_id, uint32_t log_handle, void *mod_cfg);
2625

2726
#endif /* __NATIVE_SYSTEM_AGENT_H__ */

src/library_manager/lib_manager.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,7 @@ static struct comp_dev *lib_manager_module_create(const struct comp_driver *drv,
577577
/* Intel modules expects DW size here */
578578
mod_cfg.size = args->size >> 2;
579579

580-
((struct comp_driver *)drv)->adapter_ops = native_system_agent_start(NULL, module_entry_point,
580+
((struct comp_driver *)drv)->adapter_ops = native_system_agent_start(module_entry_point,
581581
module_id, instance_id,
582582
0, log_handle,
583583
&mod_cfg);

0 commit comments

Comments
 (0)