Skip to content

Commit 261d352

Browse files
authored
Use latest dynamic-contract dependency (#499)
* Install latest dynamic-contracts deps * Update contracts that use BaseRouter
1 parent ff3a3e9 commit 261d352

File tree

5 files changed

+27
-14
lines changed

5 files changed

+27
-14
lines changed

contracts/prebuilts/account/dynamic/DynamicAccount.sol

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ pragma solidity ^0.8.11;
77

88
import "../utils/AccountCore.sol";
99

10-
import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouterWithDefaults.sol";
10+
import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouter.sol";
1111

1212
// $$\ $$\ $$\ $$\ $$\
1313
// $$ | $$ | \__| $$ | $$ |
@@ -18,18 +18,24 @@ import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouterWithDefaults.sol";
1818
// \$$$$ |$$ | $$ |$$ |$$ | \$$$$$$$ |\$$$$$\$$$$ |\$$$$$$$\ $$$$$$$ |
1919
// \____/ \__| \__|\__|\__| \_______| \_____\____/ \_______|\_______/
2020

21-
contract DynamicAccount is AccountCore, BaseRouterWithDefaults {
21+
contract DynamicAccount is AccountCore, BaseRouter {
2222
/*///////////////////////////////////////////////////////////////
23-
Constructor
23+
Constructor and Initializer
2424
//////////////////////////////////////////////////////////////*/
2525

2626
constructor(IEntryPoint _entrypoint, Extension[] memory _defaultExtensions)
2727
AccountCore(_entrypoint, msg.sender)
28-
BaseRouterWithDefaults(_defaultExtensions)
28+
BaseRouter(_defaultExtensions)
2929
{
3030
_disableInitializers();
3131
}
3232

33+
/// @notice Initializes the smart contract wallet.
34+
function initialize(address _defaultAdmin, bytes calldata) public override initializer {
35+
__BaseRouter_init();
36+
_setAdmin(_defaultAdmin, true);
37+
}
38+
3339
/*///////////////////////////////////////////////////////////////
3440
Internal overrides
3541
//////////////////////////////////////////////////////////////*/

contracts/prebuilts/account/managed/ManagedAccountFactory.sol

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
pragma solidity ^0.8.12;
33

44
// Utils
5-
import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouterWithDefaults.sol";
5+
import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouter.sol";
66
import "../utils/BaseAccountFactory.sol";
77

88
// Extensions
@@ -21,15 +21,16 @@ import { ManagedAccount, IEntryPoint } from "./ManagedAccount.sol";
2121
// \$$$$ |$$ | $$ |$$ |$$ | \$$$$$$$ |\$$$$$\$$$$ |\$$$$$$$\ $$$$$$$ |
2222
// \____/ \__| \__|\__|\__| \_______| \_____\____/ \_______|\_______/
2323

24-
contract ManagedAccountFactory is BaseAccountFactory, ContractMetadata, PermissionsEnumerable, BaseRouterWithDefaults {
24+
contract ManagedAccountFactory is BaseAccountFactory, ContractMetadata, PermissionsEnumerable, BaseRouter {
2525
/*///////////////////////////////////////////////////////////////
2626
Constructor
2727
//////////////////////////////////////////////////////////////*/
2828

2929
constructor(IEntryPoint _entrypoint, Extension[] memory _defaultExtensions)
30-
BaseRouterWithDefaults(_defaultExtensions)
30+
BaseRouter(_defaultExtensions)
3131
BaseAccountFactory(payable(address(new ManagedAccount(_entrypoint, address(this)))), address(_entrypoint))
3232
{
33+
__BaseRouter_init();
3334
_setupRole(DEFAULT_ADMIN_ROLE, msg.sender);
3435
}
3536

contracts/prebuilts/unaudited/burn-to-claim-drop/BurnToClaimDropERC721.sol

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ pragma solidity ^0.8.11;
1212
// \$$$$ |$$ | $$ |$$ |$$ | \$$$$$$$ |\$$$$$\$$$$ |\$$$$$$$\ $$$$$$$ |
1313
// \____/ \__| \__|\__|\__| \_______| \_____\____/ \_______|\_______/
1414

15-
import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouterWithDefaults.sol";
15+
import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouter.sol";
1616

1717
import "../../../extension/Multicall.sol";
1818

@@ -34,7 +34,7 @@ contract BurnToClaimDropERC721 is
3434
Initializable,
3535
Multicall,
3636
ERC2771ContextUpgradeable,
37-
BaseRouterWithDefaults,
37+
BaseRouter,
3838
DefaultOperatorFiltererInit,
3939
ContractMetadataInit,
4040
PlatformFeeInit,
@@ -48,7 +48,7 @@ contract BurnToClaimDropERC721 is
4848
Constructor + initializer logic
4949
//////////////////////////////////////////////////////////////*/
5050

51-
constructor(Extension[] memory _extensions) BaseRouterWithDefaults(_extensions) {
51+
constructor(Extension[] memory _extensions) BaseRouter(_extensions) {
5252
_disableInitializers();
5353
}
5454

@@ -65,6 +65,9 @@ contract BurnToClaimDropERC721 is
6565
uint128 _platformFeeBps,
6666
address _platformFeeRecipient
6767
) external initializer {
68+
// Initialize extensions
69+
__BaseRouter_init();
70+
6871
// Initialize inherited contracts, most base-like -> most derived.
6972
__ERC2771Context_init(_trustedForwarders);
7073
__ERC721A_init(_name, _symbol);

contracts/prebuilts/unaudited/evolving-nfts/EvolvingNFT.sol

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ pragma solidity ^0.8.11;
1212
// \$$$$ |$$ | $$ |$$ |$$ | \$$$$$$$ |\$$$$$\$$$$ |\$$$$$$$\ $$$$$$$ |
1313
// \____/ \__| \__|\__|\__| \_______| \_____\____/ \_______|\_______/
1414

15-
import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouterWithDefaults.sol";
15+
import "@thirdweb-dev/dynamic-contracts/src/presets/BaseRouter.sol";
1616

1717
import "../../../extension/Multicall.sol";
1818
import "../../../extension/upgradeable/Initializable.sol";
@@ -27,7 +27,7 @@ import "../../../extension/upgradeable/init/DefaultOperatorFiltererInit.sol";
2727

2828
contract EvolvingNFT is
2929
Initializable,
30-
BaseRouterWithDefaults,
30+
BaseRouter,
3131
Multicall,
3232
ERC721AQueryableInit,
3333
ERC2771ContextInit,
@@ -41,7 +41,7 @@ contract EvolvingNFT is
4141
/// @dev Only MINTER_ROLE holders can sign off on `MintRequest`s.
4242
bytes32 private constant EXTENSION_ROLE = keccak256("EXTENSION_ROLE");
4343

44-
constructor(Extension[] memory _extensions) BaseRouterWithDefaults(_extensions) {
44+
constructor(Extension[] memory _extensions) BaseRouter(_extensions) {
4545
_disableInitializers();
4646
}
4747

@@ -58,6 +58,9 @@ contract EvolvingNFT is
5858
) external initializer initializerERC721A {
5959
bytes32 _transferRole = keccak256("TRANSFER_ROLE");
6060

61+
// Initialize extensions
62+
__BaseRouter_init();
63+
6164
// Initialize inherited contracts, most base-like -> most derived.
6265
__ERC2771Context_init(_trustedForwarders);
6366
__ERC721A_init(_name, _symbol);

0 commit comments

Comments
 (0)