From 4abc9ee26bd9fa69ae348500f2b9a9c4cea0bc82 Mon Sep 17 00:00:00 2001 From: Ben Drucker Date: Tue, 12 Aug 2025 17:42:22 -0700 Subject: [PATCH 1/3] test on more versions --- .github/workflows/test.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 389dd0e..31cc067 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -9,7 +9,10 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [8] + node-version: + - '8' + - '12' + - '20' steps: - uses: actions/checkout@v4 - name: Setup Python 3.8 From a62346fbeb8f06f452bbbd2e01696fb033ffedc8 Mon Sep 17 00:00:00 2001 From: Ben Drucker Date: Tue, 12 Aug 2025 17:44:37 -0700 Subject: [PATCH 2/3] rm native-hello-world --- .github/workflows/test.yml | 4 ---- package.json | 1 - test/proxyquire-global.js | 6 ++++-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 31cc067..944c4ea 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,10 +15,6 @@ jobs: - '20' steps: - uses: actions/checkout@v4 - - name: Setup Python 3.8 - uses: actions/setup-python@v4 - with: - python-version: '3.8' - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 with: diff --git a/package.json b/package.json index f6b887d..8232e0c 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,6 @@ "license": "MIT", "devDependencies": { "mocha": "^5.2.0", - "native-hello-world": "^1.0.0", "should": "^13.2.3", "sinon": "^7.3.2", "standard": "^13.0.1" diff --git a/test/proxyquire-global.js b/test/proxyquire-global.js index 6fcd466..046e4d9 100644 --- a/test/proxyquire-global.js +++ b/test/proxyquire-global.js @@ -45,8 +45,10 @@ describe('global flags set', function () { } } - proxyquire('native-hello-world', stubs) - proxyquire('native-hello-world', stubs) + // Using 'crypto' instead of 'native-hello-world' as it's a built-in native module + // that's always available and doesn't require compilation + proxyquire('crypto', stubs) + proxyquire('crypto', stubs) }) }) From bd0b61c125c44341405d5626a577ff24a5575bd0 Mon Sep 17 00:00:00 2001 From: Ben Drucker Date: Tue, 12 Aug 2025 17:46:06 -0700 Subject: [PATCH 3/3] node 22 --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 944c4ea..49db176 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -12,7 +12,7 @@ jobs: node-version: - '8' - '12' - - '20' + - '22' steps: - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }}