From 0435b080075f0df36b79659bdc7a3be1bde3e8e5 Mon Sep 17 00:00:00 2001 From: Adriano Skroch Date: Wed, 19 Oct 2016 17:26:00 -0200 Subject: [PATCH] Check if the "a" element has a "href" attribute --- lib/cleaner/remove-navigational-elements.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/cleaner/remove-navigational-elements.js b/lib/cleaner/remove-navigational-elements.js index 7985ebf..74051b8 100644 --- a/lib/cleaner/remove-navigational-elements.js +++ b/lib/cleaner/remove-navigational-elements.js @@ -11,8 +11,9 @@ module.exports = function (rawHtml, host) { // Filter out 'back to top' links $('a').filter(function () { + var href = $(this).attr('href'); var hasTopInText = $(this).text().toLowerCase().indexOf('top') > -1; - var hasHashInHref = $(this).attr('href').indexOf('#') > -1; + var hasHashInHref = href && href.indexOf('#') > -1; return hasTopInText && hasHashInHref; }).remove(); @@ -23,7 +24,7 @@ module.exports = function (rawHtml, host) { var isRelTag = relTag === 'tag'; var isPartOfList = $(this).parents('ul').length > 0; - var containsUrlWithTag = href.indexOf(host) > -1 && href.indexOf('tag') > -1; + var containsUrlWithTag = href && href.indexOf(host) > -1 && href.indexOf('tag') > -1; if (isRelTag || containsUrlWithTag) { if (isPartOfList) {