From c6b20b3c19fdbc01607b4785fcf5709dcd603d76 Mon Sep 17 00:00:00 2001 From: Matheus Richard Date: Thu, 22 May 2025 16:41:44 -0300 Subject: [PATCH 1/2] Avoid weasel words/justification filler phrases --- code-review/README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/code-review/README.md b/code-review/README.md index daad5ea5..c19daba8 100644 --- a/code-review/README.md +++ b/code-review/README.md @@ -27,6 +27,10 @@ Watch a presentation that covers this material from [Derek Prior at RailsConf 20 - **Avoid diminishing words** - "simply", "simple", "just" +- **Avoid [weasel words]/[justification filler phrases]** + - "Researchers say that", "it's a best practice". + - Be cliear and explain the tradeoffs and impacts of a particular solution. + - **Be explicit** - Remember people don't always understand your intentions online. @@ -133,3 +137,5 @@ This helps us have more meaningful conversations on PRs rather than debating per [challenging to convey emotion and intention online]: https://thoughtbot.com/blog/empathy-online [using labels]: https://conventionalcomments.org [standard]: https://github.com/testdouble/standard +[weasel words]: https://en.wikipedia.org/wiki/Weasel_word +[justification filler phrases]: https://serce.me/posts/2025-05-19-justification-filler-phrases From e6b7cc2362ac281e9254ff4c22ae6bbe0ed51a9a Mon Sep 17 00:00:00 2001 From: Matheus Richard Date: Thu, 22 May 2025 17:32:08 -0300 Subject: [PATCH 2/2] typo Co-authored-by: louis-antonopoulos --- code-review/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code-review/README.md b/code-review/README.md index c19daba8..2530b689 100644 --- a/code-review/README.md +++ b/code-review/README.md @@ -29,7 +29,7 @@ Watch a presentation that covers this material from [Derek Prior at RailsConf 20 - **Avoid [weasel words]/[justification filler phrases]** - "Researchers say that", "it's a best practice". - - Be cliear and explain the tradeoffs and impacts of a particular solution. + - Be clear and explain the tradeoffs and impacts of a particular solution. - **Be explicit** - Remember people don't always understand your intentions online.