From 202e8de2f80df74b9af946f9a579465dab22a633 Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Wed, 6 Jan 2021 12:08:53 +0200 Subject: [PATCH 01/10] Update jsng-ci.yml to use multiple ubuntu versions running ci workflow on Ubuntu 20.0, Ubuntu 18.04 and Ubuntu 16.04 --- .github/workflows/jsng-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index 17c2288e9..cceb70ec9 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -11,9 +11,10 @@ on: jobs: build: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} strategy: matrix: + os: [ubuntu-16.04, ubuntu-18.04, ubuntu-20.04] python-version: [3.6, 3.7, 3.8] steps: - uses: actions/checkout@v2 From 3a553c01a66639f98222b2698e03df16ec7570fd Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Wed, 6 Jan 2021 12:26:53 +0200 Subject: [PATCH 02/10] Update jsng-ci.yml remove ubuntu 16.04 --- .github/workflows/jsng-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index cceb70ec9..7b737be4f 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -14,7 +14,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ubuntu-16.04, ubuntu-18.04, ubuntu-20.04] + os: [ubuntu-18.04, ubuntu-20.04] python-version: [3.6, 3.7, 3.8] steps: - uses: actions/checkout@v2 From af8d6552f0210cb40c44b466f742dbc41a133663 Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Mon, 11 Jan 2021 15:20:50 +0200 Subject: [PATCH 03/10] Update jsng-ci.yml - including additional values into combinations - Prevents a workflow run from failing when a job fails only for experimental jobs with both ubuntu 20.04 and python 3.9 - prevent GitHub cancels all in-progress jobs if any matrix job fails. to allow us to know the results for all jobs, even if one fails. - maximize the number of jobs that can run simultaneously when using a matrix job strategy. --- .github/workflows/jsng-ci.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index 7b737be4f..b04454fc8 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -12,10 +12,19 @@ on: jobs: build: runs-on: ${{ matrix.os }} + continue-on-error: ${{ matrix.experimental }} strategy: + fail-fast: false + max-parallel: 9 matrix: - os: [ubuntu-18.04, ubuntu-20.04] python-version: [3.6, 3.7, 3.8] + os: [ubuntu-18.04] + experimental: [false] + include: + - python-version: 3.9 + experimental: true + - os: ubuntu-20.04 + experimental: true steps: - uses: actions/checkout@v2 - name: Set up Python ${{ matrix.python-version }} From 943c0c820cc8134da936494c9fdd9bd13e42a5b4 Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Mon, 11 Jan 2021 15:39:42 +0200 Subject: [PATCH 04/10] fix for Unexpected value '' evaluating 'runs-on' --- .github/workflows/jsng-ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index b04454fc8..99d98b9fe 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -17,13 +17,15 @@ jobs: fail-fast: false max-parallel: 9 matrix: - python-version: [3.6, 3.7, 3.8] os: [ubuntu-18.04] + python-version: [3.6, 3.7, 3.8] experimental: [false] include: - python-version: 3.9 + os: ${{ matrix.os }} experimental: true - os: ubuntu-20.04 + python-versiob: ${{ matrix.python-version }} experimental: true steps: - uses: actions/checkout@v2 From 8b6856b6d685fb3a5be7484c9a39b2c8680c7d0c Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Mon, 11 Jan 2021 15:44:31 +0200 Subject: [PATCH 05/10] Update jsng-ci.yml --- .github/workflows/jsng-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index 99d98b9fe..1cdb9cb15 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -22,10 +22,8 @@ jobs: experimental: [false] include: - python-version: 3.9 - os: ${{ matrix.os }} experimental: true - os: ubuntu-20.04 - python-versiob: ${{ matrix.python-version }} experimental: true steps: - uses: actions/checkout@v2 From 51fb2428163275d4db6f6feb3d89757a9e6a059c Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Mon, 11 Jan 2021 16:04:29 +0200 Subject: [PATCH 06/10] fix -hopefully- err when evaluating 'runs-on' --- .github/workflows/jsng-ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index 1cdb9cb15..75e3d0c66 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -15,14 +15,12 @@ jobs: continue-on-error: ${{ matrix.experimental }} strategy: fail-fast: false - max-parallel: 9 + # max-parallel: 9 matrix: os: [ubuntu-18.04] python-version: [3.6, 3.7, 3.8] experimental: [false] include: - - python-version: 3.9 - experimental: true - os: ubuntu-20.04 experimental: true steps: From 6133a11ed4acde6c3f5f290997121d73fa6614bb Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Mon, 11 Jan 2021 16:10:07 +0200 Subject: [PATCH 07/10] Update jsng-ci.yml --- .github/workflows/jsng-ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index 75e3d0c66..97937aba2 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -22,6 +22,10 @@ jobs: experimental: [false] include: - os: ubuntu-20.04 + python-version: 3.8 + experimental: true + - python-version: 3.9 + os: ubuntu-18.04 experimental: true steps: - uses: actions/checkout@v2 From b85ee131003e04ac036bec04ca98e6482c77c03b Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Mon, 11 Jan 2021 17:23:45 +0200 Subject: [PATCH 08/10] Update jsng-ci.yml adding names to experimental jobs. --- .github/workflows/jsng-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index 97937aba2..2b8f017f0 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -24,9 +24,11 @@ jobs: - os: ubuntu-20.04 python-version: 3.8 experimental: true + name: Experimental testing - Ubuntu 20.04 (Python 3.8) - python-version: 3.9 os: ubuntu-18.04 experimental: true + name: Experimental testing - Python 3.9 (Ubuntu 18.04) steps: - uses: actions/checkout@v2 - name: Set up Python ${{ matrix.python-version }} From 432e8fbb3f0558cca89968508ce8648d479e0fb5 Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Mon, 11 Jan 2021 17:30:48 +0200 Subject: [PATCH 09/10] changes to jobs names --- .github/workflows/jsng-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index 2b8f017f0..1915ea691 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -24,11 +24,11 @@ jobs: - os: ubuntu-20.04 python-version: 3.8 experimental: true - name: Experimental testing - Ubuntu 20.04 (Python 3.8) + name: Experimental build - latest Ubuntu - python-version: 3.9 os: ubuntu-18.04 experimental: true - name: Experimental testing - Python 3.9 (Ubuntu 18.04) + name: Experimental build - latest Python steps: - uses: actions/checkout@v2 - name: Set up Python ${{ matrix.python-version }} From 5a6d3d0b8b2ce503ea427ec73986ba957c2ab27e Mon Sep 17 00:00:00 2001 From: Sameh Abouel-saad Date: Tue, 12 Jan 2021 14:05:18 +0200 Subject: [PATCH 10/10] Adding net-tools utilities to deps in CI workflow netstat not available in recent Ubuntu versions. it is not installed by default and considered deprecated in favor of the modern ss command. as some tests used netstat, this commit bing it back by installing net-tools utilities --- .github/workflows/jsng-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/jsng-ci.yml b/.github/workflows/jsng-ci.yml index 1915ea691..652857f7e 100644 --- a/.github/workflows/jsng-ci.yml +++ b/.github/workflows/jsng-ci.yml @@ -38,7 +38,7 @@ jobs: - name: Gathering deps run: | sudo apt-get update - sudo apt-get install -y git python3-setuptools tmux redis + sudo apt-get install -y git python3-setuptools tmux redis net-tools sudo pip3 install poetry - name: Install run: |