Skip to content

Commit 78b2e3c

Browse files
Remove check of environment in deployments jobs
Right now we only support `goerli` network and we expect that the workflow (when triggered manually) is always dispatched with this `environment`. Previously we introduced `github.event.inputs.environment == 'goerli'` condition to not run the deploy job if workflow gets accidentally run on a different environment. But even without this condition we don't risk publishing of a package with some invalid contracts - deploy will fail either due to unsupported `environment` or due to incorrect account being used. Actually, returning error instead of cleanly exiting the workflow may be a better idea in case wrong `environment` is provided - this will alarm the scheduler that something went wrong with the deployment.
1 parent bb47f4f commit 78b2e3c

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

.github/workflows/contracts.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ jobs:
118118
needs: [contracts-build-and-test]
119119
if: |
120120
github.event_name == 'workflow_dispatch'
121-
&& github.event.inputs.environment == 'goerli'
122121
&& github.ref != 'refs/heads/dapp-development'
123122
runs-on: ubuntu-latest
124123
steps:
@@ -224,7 +223,6 @@ jobs:
224223
needs: [contracts-build-and-test]
225224
if: |
226225
github.event_name == 'workflow_dispatch'
227-
&& github.event.inputs.environment == 'goerli'
228226
&& github.ref == 'refs/heads/dapp-development'
229227
runs-on: ubuntu-latest
230228
steps:

0 commit comments

Comments
 (0)