Merge pull request #110 from threshold-network/permit-top-up

Allow anyone to top-up any staking provider with liquid T

Author: pdyraga

contracts/staking/IStaking.sol

@@ -181,7 +181,6 @@ interface IStaking {
     //
 
     /// @notice Increases the amount of the stake for the given staking provider.
-    ///         Can be called only by the owner or the staking provider.
     /// @dev The sender of this transaction needs to have the amount approved to
     ///      transfer to the staking contract.
     function topUp(address stakingProvider, uint96 amount) external;

contracts/staking/TokenStaking.sol

@@ -714,14 +714,13 @@ contract TokenStaking is Initializable, IStaking, Checkpoints {
     //
 
     /// @notice Increases the amount of the stake for the given staking provider.
-    ///         Can be called only by the owner or the staking provider.
     /// @dev The sender of this transaction needs to have the amount approved to
     ///      transfer to the staking contract.
-    function topUp(address stakingProvider, uint96 amount)
-        external
-        override
-        onlyOwnerOrStakingProvider(stakingProvider)
-    {
+    function topUp(address stakingProvider, uint96 amount) external override {
+        require(
+            stakingProviders[stakingProvider].owner != address(0),
+            "Nothing to top-up"
+        );
         require(amount > 0, "Parameters must be specified");
         StakingProviderInfo storage stakingProviderStruct = stakingProviders[
             stakingProvider

docs/rfc-1-staking-contract.adoc

@@ -389,11 +389,11 @@ protect against DoSing slashing queue. Can only be called by the governance.
 
 === Stake top-up
 
-==== `topUp(address stakingProvider, uint96 amount) external onlyOwnerOrStakingProvider(stakingProvider)`
+==== `topUp(address stakingProvider, uint96 amount) external`
 
 Increases the amount of the stake for the given staking provider. The sender of this
 transaction needs to have the amount approved to transfer to the staking
-contract. Can be called only by the owner or staking provider.
+contract.
 
 ==== `topUpKeep(address stakingProvider) external onlyOwnerOrStakingProvider(stakingProvider)`
 

test/staking/TokenStaking.test.js

@@ -2730,28 +2730,7 @@ describe("TokenStaking", () => {
           tokenStaking
             .connect(stakingProvider)
             .topUp(stakingProvider.address, initialStakerBalance)
-        ).to.be.revertedWith("Not owner or provider")
-      })
-    })
-
-    context("when caller is not owner or staking provider", () => {
-      it("should revert", async () => {
-        await tToken
-          .connect(staker)
-          .approve(tokenStaking.address, initialStakerBalance)
-        await tokenStaking
-          .connect(staker)
-          .stake(
-            stakingProvider.address,
-            staker.address,
-            staker.address,
-            initialStakerBalance
-          )
-        await expect(
-          tokenStaking
-            .connect(authorizer)
-            .topUp(stakingProvider.address, initialStakerBalance)
-        ).to.be.revertedWith("Not owner or provider")
+        ).to.be.revertedWith("Nothing to top-up")
       })
     })
 
@@ -2938,10 +2917,12 @@ describe("TokenStaking", () => {
         await tokenStaking
           .connect(staker)
           .delegateVoting(stakingProvider.address, delegatee.address)
-        await tToken.connect(deployer).transfer(staker.address, topUpAmount)
-        await tToken.connect(staker).approve(tokenStaking.address, topUpAmount)
+        await tToken.connect(deployer).transfer(authorizer.address, topUpAmount)
+        await tToken
+          .connect(authorizer)
+          .approve(tokenStaking.address, topUpAmount)
         tx = await tokenStaking
-          .connect(staker)
+          .connect(authorizer)
           .topUp(stakingProvider.address, topUpAmount)
       })