Authorization confirmation modal updates #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing word `app` in the staking app card. Fix typo `RANDOMBEACON -> RANDOM BEACON`.
Add missing denominator- next to the amount of T authorized the T denominator should be displayed.
michalsmiarowski
requested changes
Oct 24, 2022
Contributor
michalsmiarowski
left a comment
michalsmiarowski
left a comment
There was a problem hiding this comment.
Left one small comment but overall looking good 👍
src/components/Modal/StakingApplications/AuthorizeStakingApps.tsx
Outdated
Show resolved
Hide resolved
In ea991e we added a function that returns the app label based on the staking app type. This commit uses this function instead of a custom map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #253
This PR updates the authorization confirmation modal. Main changes are:
appin the staking app card,RANDOMBEACON -> RANDOM BEACON,