Skip to content

Commit 6405090

Browse files
committed
[WEB-3766] Refactor pump settings parameter handling for continuous data
Restructures how pump settings parameters are constructed and passed to improve accuracy for continuous vs non-continuous datasets. Adds conditional logic to set endDate only for continuous data and includes debug logging for better traceability.
1 parent 7b10790 commit 6405090

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

lib/report.mjs

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -888,15 +888,21 @@ class Report {
888888
endDateBound = moment.utc(latestDiabetesDatum.time).toISOString();
889889
}
890890

891+
const pumpSettingsParams = {
892+
type: 'pumpSettings',
893+
uploadId: latestDiabetesDatum.uploadId,
894+
latest: 1,
895+
restricted_token: token,
896+
};
897+
898+
// Non-continuous datasets have pumpSettings records after all diabetes data
899+
if (isContinuous) {
900+
pumpSettingsParams.endDate = endDateBound;
901+
}
902+
891903
return {
892904
latestDiabetesDatum,
893-
pumpSettingsParams: {
894-
type: 'pumpSettings',
895-
uploadId: latestDiabetesDatum.uploadId,
896-
latest: 1,
897-
endDate: endDateBound,
898-
restricted_token: token,
899-
},
905+
pumpSettingsParams,
900906
pumpSettingsHeaders: {
901907
headers: sessionHeader,
902908
},
@@ -961,10 +967,13 @@ class Report {
961967
end,
962968
this.#requestData.token,
963969
this.#requestData.sessionHeader,
970+
this.#log,
964971
);
965972

966973
let pumpSettingsToAdd = null;
967974

975+
this.#log.debug('pumpSettingsParams ', pumpSettingsParams);
976+
968977
if (pumpSettingsParams) {
969978
const pumpSettingsForUploadFetch = await fetchUserData(
970979
this.#userDetail.userId,

0 commit comments

Comments
 (0)