Error Handling for MFA required

[PaulCavill]

I'm calling PyiCloudService.authenticate() before performing any actions. However, when 2FA is required, I’m not seeing any errors raised, and requires_2fa remains False.

2025-07-15 20:26:46.312 DEBUG [pyicloud.base] Checking session token validity
2025-07-15 20:26:47.520 DEBUG [pyicloud.base] Session token is still valid
2025-07-15 20:26:47.521 DEBUG [pyicloud.base] Authentication completed successfully
2025-07-15 20:26:47.521 DEBUG [icloud.account] Updating devices
2025-07-15 20:26:48.149 DEBUG [pyicloud.base] Authenticating as apple@apple.com
2025-07-15 20:26:52.915 DEBUG [pyicloud.base] 2FA required to complete authentication.
2025-07-15 20:26:55.662 DEBUG [pyicloud.base] 2FA is required
2025-07-15 20:26:55.662 DEBUG [pyicloud.base] Authentication completed successfully

Is this the intended behavior? Should the caller infer that 2FA is required from the logs, or should an exception be raised or requires_2fa be set to True in this case?

pyicloud/pyicloud/base.py

Lines 243 to 247 in 0cba718

	if not login_successful:
	try:
	self._authenticate()
	except PyiCloud2FARequiredException:
	LOGGER.debug("2FA is required")

[PaulCavill]

@timlaing

[timlaing]

sorry for the slow response - have been dealing with some family issues. I will have a look at this over the next couple of days.

[timlaing]

Looking at the code this does look like an issue. Can you confirm if 2FA was needed or is it an logging error?

[PaulCavill]

Yes mfa is required.
Device tracking info stops changing and a sign in / code request shows on my devices.

After checking for a couple of months the log lines up with the code request.

[timlaing]

Many thanks. I think I now have a fix for this as well - going to be testing it out over the next few days.

[timlaing]

I believe this has now been fixed in PR #124. @PaulCavill - if you want to test this it would be great.

[PaulCavill]

@timlaing, I have this running now will montior.

[timlaing]

I have merged this into main. Sorry for the delay

[PaulCavill]

@timlaing Sorry for the late responce, my MFA expired today and i got the MFA prompt on my device once,. then the HA integration stop polling as expected.

Thank you for your work :).