Skip to content

Commit 4428dec

Browse files
committed
respond to some feedback
1 parent e786ac0 commit 4428dec

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/qos_client/RESHARD_GUIDE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ qos_client boot-reshard \
4141

4242
### 3 - Get attestation doc (Old Share Holder)
4343

44-
Get the attestation doc from the enclave. The attestation doc contains a refference to the reshard input and the ephemeral key which shares will be encrypted.
44+
Get the attestation doc from the enclave. The attestation doc contains a reference to the reshard input and the ephemeral key which shares will be encrypted.
4545

4646
```sh
4747
qos_client get-reshard-attestation-doc \
@@ -62,7 +62,7 @@ For each quorum key being resharded, the user will need a separate directory wit
6262
- my_alias.share
6363
```
6464

65-
Note that the logic looks at the extension of the file to determine if its a share or the quorum key.
65+
Note that the logic looks at the extension of the file to determine if it's a share or the quorum key.
6666

6767
```sh
6868
qos_client reshard-re-encrypt-share \
@@ -84,7 +84,7 @@ Post the re-encrypted shares from last step in order to reconstruct the quorum k
8484

8585
```sh
8686
qos_client reshard-post-share
87-
--provision-input-path <write: path to the file to write this users provision input> \
87+
--provision-input-path <write: path to the file to write this users ReshardProvisionInput> \
8888
--host-port 3001 \
8989
--host-ip localhost
9090
```

src/qos_core/src/protocol/services/reshard.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ pub struct ReshardProvisionInput {
7474
pub struct ReshardInput {
7575
/// List of quorum public keys
7676
pub quorum_keys: Vec<Vec<u8>>,
77-
/// The set and threshold to shard the key.
77+
/// The share set and threshold to shard the quorum keys to.
7878
pub new_share_set: ShareSet,
79-
/// The set the key is currently sharded too.
79+
/// The share set the quorum keys are currently sharded too.
8080
pub old_share_set: ShareSet,
8181
/// The expected configuration of the enclave. Useful to verify the
8282
/// attestation document against. We also want those posting shares to
@@ -289,7 +289,7 @@ pub(in crate::protocol) fn reshard_provision(
289289
reshard_input.new_share_set.threshold as usize,
290290
);
291291

292-
// Now, lets create the new shards
292+
// Now, let's create the new shards
293293
let member_outputs =
294294
zip(shares, reshard_input.new_share_set.members.iter().cloned())
295295
.map(|(share, share_set_member)| -> Result<GenesisMemberOutput, ProtocolError> {

0 commit comments

Comments
 (0)