-
Notifications
You must be signed in to change notification settings - Fork 20
Upgrade to newer aws-nitro-enclaves-cli #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d3cbce5 to
4017517
Compare
|
Rebased on top of the now-merged #504 to fix build problems. |
…nor versions Additional steps: harmonize the libc minimum version
4017517 to
eee0eab
Compare
|
CI issues are resolved. I'm working on the dependency security review. |
|
The dependency security review is complete (see internal documentation) and this PR is ready to merge. |
r-n-o
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of it looks reasonable. My only point of concern is utf8parse. I can't find a trusted source for it.
|
The |
|
@r-n-o as commented inline, some of the new-appearing crate entries in It's still useful that you had a look at them, good sanity checking! |
Summary & Motivation (Problem vs. Solution)
We rely on several AWS NSM crates. After a long break, AWS released a new version of
aws-nitro-enclaves-clithat we should adopt, see here for changelog information.Along the way
aws-nitro-enclaves-nsm-api, which is basically just a MSRV updateCargo.lockentriesThese changes move us closer to getting rid of the unmaintained
attycrate, which is now removed in most places through a switch toclap4.x that doesn't depend on it anymore. Unfortunately, one usage site remains withaws-nitro-enclaves-image-format, which still depends onclap3.x even in a recent version.The dependency changes bring a lot of review tasks:
17 of the completely new crates are
aws-*crates, which helps a bit to establish trustworthiness.At the moment,
aws-nitro-enclaves-clidoesn't have Cargo features we can disable, so this dependency load is hard to reduce from my perspective.How I Tested These Changes
Local unit tests.
This change needs thorough testing in various testing environments.
Pre merge check list