-
Notifications
You must be signed in to change notification settings - Fork 5
Removal of accented letters on cluster_gen is OS-dependent #46
Copy link
Copy link
Open
Labels
Description
This issue concerns the following code chunk:
Lines 184 to 187 in e398e1e
| # Removing accents ====================================================== | |
| if (!is.null(names(n))) names(n) <- iconv(names(n), to = "ASCII//TRANSLIT") | |
| cluster_labels <- iconv(cluster_labels, to = "ASCII//TRANSLIT") | |
| resp_labels <- iconv(resp_labels, to = "ASCII//TRANSLIT") |
It is intended to produce the following kind of output:
However, this seems to not be OS-agnostic. During the lsasim 2.1.0 release cycle, I was made aware that this works on Windows and mainstream Linux distributions, but Intel Macs and Solaris yield a different output. It was also noted that some Linux distributions such as Alpine (not tested by CRAN) do not even support "//TRANSLIT" at all.
It would be ideal if this feature was thus made more universal. Alternatively, it could be dropped, and accented letters would either be parsed directly or trigger a warning/error.
Reactions are currently unavailable
