Get log date for my_logs() (#120)

Author: S0S-90

pycaching/cache.py

@@ -11,7 +11,7 @@
 from pycaching.log import Log, Type as LogType
 from pycaching.util import parse_date, rot13, lazy_loaded
 
-# prefix _type() function to avoid colisions with cache type
+# prefix _type() function to avoid collisions with cache type
 _type = type
 
 
@@ -167,7 +167,7 @@ def __init__(self, geocaching, wp, **kwargs):
         known_kwargs = {"name", "type", "location", "original_location", "state", "found", "size",
                         "difficulty", "terrain", "author", "hidden", "attributes", "summary",
                         "description", "hint", "favorites", "pm_only", "url", "waypoints", "_logbook_token",
-                        "_trackable_page_url", "guid"}
+                        "_trackable_page_url", "guid", "visited"}
 
         for name in known_kwargs:
             if name in kwargs:
@@ -463,6 +463,25 @@ def hidden(self, hidden):
                 "Passed object is not datetime.date instance nor string containing a date.")
         self._hidden = hidden
 
+    @property
+    def visited(self):
+        """The cache log date (filled by function geocaching.my_logs() if cache is created there)
+
+        :setter: Set a cache log date. If :class:`str` is passed, then :meth:`.util.parse_date`
+            is used and its return value is stored as a date.
+        :type: :class:`datetime.date`
+        """
+        return self._visited
+
+    @visited.setter
+    def visited(self, visited):
+        if isinstance(visited, str):
+            visited = parse_date(visited)
+        elif not isinstance(visited, datetime.date):
+            raise errors.ValueError(
+                "Passed object is not datetime.date instance nor string containing a date.")
+        self._visited = visited
+
     @property
     @lazy_loaded
     def attributes(self):

pycaching/geocaching.py

@@ -408,19 +408,22 @@ def my_logs(self, log_type=None, limit=float('inf')):
                 log_type = log_type.value
             url += '?lt={lt}'.format(lt=log_type)
         cache_table = self._request(url).find(class_='Table')
-        if cache_table is None:  # no finds on the account
+        if cache_table is None:  # no logs on the account
             return
         cache_table = cache_table.tbody
 
         yielded = 0
         for row in cache_table.find_all('tr'):
-            link = row.find(class_='ImageLink')['href']
-            guid = parse_qs(urlparse(link).query)['guid'][0]
-
             if yielded >= limit:
                 break
 
-            yield self._try_getting_cache_from_guid(guid)
+            link = row.find(class_='ImageLink')['href']
+            guid = parse_qs(urlparse(link).query)['guid'][0]
+            current_cache = self._try_getting_cache_from_guid(guid)
+            date = row.find_all('td')[2].text.strip()
+            current_cache.visited = date
+
+            yield current_cache
             yielded += 1
 
     def my_finds(self, limit=float('inf')):

test/test_cache.py

@@ -137,6 +137,16 @@ def test_hidden(self):
             with self.assertRaises(PycachingValueError):
                 self.c.hidden = None
 
+    def test_visited(self):
+
+        with self.subTest("automatic str conversion"):
+            self.c.visited = "1/30/2000"
+            self.assertEqual(self.c.visited, date(2000, 1, 30))
+
+        with self.subTest("give date object"):
+            self.c.visited = date(2000, 1, 30)
+            self.assertEqual(self.c.visited, date(2000, 1, 30))
+
     def test_attributes(self):
         self.assertEqual(self.c.attributes, {"onehour": True, "kids": False, "available": True})