`varImp` issue for GAMs

[potoole7]

caret/models/files/gam.R

Line 71 in c98cc1a

rownames(gams) <- gsub("^s\\(", "", rownames(gams))

This line won't work with different smoothers to s(), such as te, and also won't work for 2D splines, e.g. s(x1, x2).

Reprex:

library(mgcv)
library(caret)

set.seed(2) ## simulate some data... 
dat <- gamSim(1,n=400,dist="normal",scale=2)
b <- gam(y~s(x0)+te(x1, x2), data = dat)
varImp(b)
# Error in if (any(extras)) { : missing value where TRUE/FALSE needed

c <- gam(y~s(x0)+s(x1, x2), data = dat)
varImp(c)
# Error in if (any(extras)) { : missing value where TRUE/FALSE needed