You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs: update pre-commit requirements to use make test-ci
Replace linting-only requirement with comprehensive CI test suite that includes:
- Linting validation (YAML, shell scripts, markdown)
- Infrastructure tests (Terraform/OpenTofu syntax, cloud-init templates)
- Application tests (Docker Compose syntax, app configuration)
- Project tests (Makefile syntax, project structure, tool requirements)
This ensures more comprehensive validation before commits while excluding
only the slower E2E tests (~5-8 minutes) which are still recommended
before pushing changes.
Benefits:
- Earlier detection of issues across all test layers
- Better code quality through comprehensive pre-commit validation
- Faster CI/CD feedback by catching issues locally
- Consistent validation standards for all contributors
Copy file name to clipboardExpand all lines: .github/copilot-instructions.md
+10-7Lines changed: 10 additions & 7 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -542,19 +542,22 @@ This ensures that the command is executed and its output is returned to the prim
542
542
543
543
**Commit Signing Requirement**: All commits MUST be signed with GPG. When performing git commits, always use the default git commit behavior (which will trigger GPG signing) rather than `--no-gpg-sign`.
544
544
545
-
**Pre-commit Linting Requirement**: ALWAYS run the linting script before committing any changes:
545
+
**Pre-commit Testing Requirement**: ALWAYS run the CI test suite before committing any changes:
546
546
547
547
```bash
548
-
./scripts/lint.sh
548
+
make test-ci
549
549
```
550
550
551
-
This script validates:
551
+
This command runs all unit tests that don't require a virtual machine, including:
Only commit if all linting checks pass. If linting fails, fix the issues before committing.
558
+
Only commit if all CI tests pass. If any tests fail, fix the issues before committing.
559
+
560
+
**Note**: End-to-end tests (`make test`) are excluded from pre-commit requirements due to their longer execution time (~5-8 minutes), but running them before pushing is strongly recommended for comprehensive validation.
558
561
559
562
**Best Practice**: Always ask "Would you like me to commit these changes?" before performing any git state-changing operations.
0 commit comments