feat: [#24] replace custom SSH cloud-init monitoring with Ansible-based approach

- Remove reboot and custom completion marker from cloud-init configuration
- Replace custom SSH monitoring with native Ansible cloud-init waiting
- Add new Ansible playbooks for cloud-init wait and VM restart orchestration
- Simplify Provision.pm by removing complex SSH monitoring logic
- Preserve SSH infrastructure classes for future use and testing
- Improve error handling and logging with structured Ansible output
- Enhance post-provision workflow with proper VM restart management

Breaking changes:
- Cloud-init no longer auto-reboots (Ansible handles restart)
- Removed custom completion marker approach
- Updated dependencies (no longer requires sshpass)

Benefits:
- Native Ansible integration for better maintainability
- Improved reboot handling with proper reconnection logic
- Unified toolchain for all post-infrastructure operations
- Better structured error reporting and status monitoring

Author: josecelano

lib/TorrustDeploy/App/Command/Provision.pm

@@ -5,7 +5,6 @@ use v5.38;
 use TorrustDeploy::App -command;
 use TorrustDeploy::Provision::OpenTofu;
 use TorrustDeploy::Provision::Ansible;
-use TorrustDeploy::Infrastructure::SSH::Connection;
 use Path::Tiny qw(path);
 use File::Spec;
 use Time::HiRes qw(sleep);
@@ -21,10 +20,12 @@ This command will:
 1. Initialize OpenTofu if needed
 2. Copy configuration templates to the working directory
 3. Create a VM with hardcoded minimal configuration
-4. Wait for IP assignment and cloud-init completion
-5. Monitor cloud-init progress via SSH
+4. Wait for cloud-init completion using Ansible
+5. Run post-provision verification via Ansible
+6. Restart the VM after successful verification
 
 The VM will be created locally using libvirt/KVM.
+Cloud-init handles initial setup, Ansible manages the orchestration.
 END_DESCRIPTION
 }
 
@@ -56,21 +57,27 @@ sub execute {
     # Get VM IP address
     my $vm_ip = $tofu->get_vm_ip($tofu_dir);
     STDOUT->flush();
-    
-    # Create SSH connection
-    my $ssh_connection = TorrustDeploy::Infrastructure::SSH::Connection->new(host => $vm_ip);
-    
-    # Wait for cloud-init completion
-    $self->_wait_for_cloud_init($ssh_connection);
-    
+
+    # Set up Ansible working directory and copy templates
+    my $ansible_dir = $work_dir->child('ansible');
+    my $ansible = TorrustDeploy::Provision::Ansible->new();
+    $ansible->copy_templates_and_generate_inventory($vm_ip, $ansible_dir);
+
+    # Wait for cloud-init completion using Ansible
+    $ansible->wait_for_cloud_init($ansible_dir);
+
     # Run Ansible post-provision verification
-    $self->_run_ansible_verification($vm_ip, $work_dir);
+    $ansible->run_verification($ansible_dir);
+
+    # Restart VM after verification
+    $ansible->restart_vm($ansible_dir);
 
     # Final completion message
     say "";
     say "✅ Provisioning completed successfully!";
     say "VM is ready at IP: " . $vm_ip;
     say "You can connect using: ssh -i ~/.ssh/testing_rsa torrust@" . $vm_ip;
+    say "VM has been restarted and is ready for production use!";
     STDOUT->flush();
 }
 
@@ -109,185 +116,6 @@ sub _copy_templates {
     say "Templates copied successfully.";
 }
 
-sub _wait_for_cloud_init {
-    my ($self, $ssh_connection) = @_;
-    
-    say "Waiting for cloud-init to complete...";
-    say "This may take several minutes while packages are installed and configured.";
-    STDOUT->flush();
-    
-    my $completion_file = "/var/lib/cloud/torrust-setup-complete";
-    my $max_attempts = 360; # 30 minutes with 5-second intervals
-    my $attempt = 0;
-    my $ssh_connected = 0;
-    my $cloud_init_success = 0;
-    
-    # Step 1: Wait until SSH connection is available (for password auth to check cloud-init)
-    say "⏳ Waiting for SSH service to become available...";
-    STDOUT->flush();
-    
-    while ($attempt < $max_attempts && !$ssh_connected) {
-        $attempt++;
-        
-        if ($ssh_connection->test_password_connection()) {
-            $ssh_connected = 1;
-            say "✅ SSH password connection established to " . $ssh_connection->host;
-            STDOUT->flush();
-        } else {
-            if ($attempt % 6 == 0) { # Every 30 seconds
-                say "  [Waiting for SSH connection... ${attempt}0s elapsed]";
-                STDOUT->flush();
-            }
-            sleep(5);
-        }
-    }
-    
-    if (!$ssh_connected) {
-        say "❌ Failed to establish SSH connection to " . $ssh_connection->host . " after " . ($max_attempts * 5 / 60) . " minutes";
-        STDOUT->flush();
-        $self->_print_cloud_init_logs($ssh_connection);
-        die "SSH connection failed";
-    }
-    
-    # Step 2: Wait until cloud-init completion marker is created
-    say "⏳ Waiting for cloud-init to complete...";
-    STDOUT->flush();
-    
-    $attempt = 0;
-    my $consecutive_ssh_failures = 0;
-    while ($attempt < $max_attempts) {
-        $attempt++;
-        
-        my $result = $ssh_connection->execute_command("test -f $completion_file");
-        
-        # Debug: Always show result details when exit code is 0
-        if ($result->exit_code == 0) {
-            say "  [DEBUG] File exists! Exit code: " . $result->exit_code . 
-                ", Success method: " . ($result->success ? 'true' : 'false') . 
-                ", Output: '" . ($result->output // 'EMPTY') . "'";
-            STDOUT->flush();
-        }
-        
-        if ($result->success) {
-            say "✅ Cloud-init setup completed successfully!";
-            STDOUT->flush();
-            
-            # Show completion message
-            my $completion_result = $ssh_connection->execute_command("cat $completion_file");
-            if ($completion_result->success && $completion_result->output) {
-                chomp(my $output = $completion_result->output);
-                say "📅 Completion marker: " . $output;
-                STDOUT->flush();
-            }
-            $cloud_init_success = 1;
-            last;
-        } else {
-            # Track consecutive SSH failures (exit code 255)
-            if ($result->exit_code == 255) {
-                $consecutive_ssh_failures++;
-                # If we have too many consecutive SSH failures, try to re-establish password connection
-                if ($consecutive_ssh_failures >= 12) { # 1 minute of consecutive failures
-                    say "⚠️ SSH connection lost, attempting to re-establish (VM may be rebooting)...";
-                    say "  [Waiting 30s for VM to complete reboot...]";
-                    STDOUT->flush();
-                    sleep(30); # Give VM time to fully reboot
-                    
-                    # Try to re-establish password connection (VM might have rebooted)
-                    my $reconnect_attempts = 0;
-                    while ($reconnect_attempts < 12 && !$ssh_connection->test_password_connection()) {
-                        $reconnect_attempts++;
-                        say "  [Reconnection attempt $reconnect_attempts/12...]";
-                        STDOUT->flush();
-                        sleep(15); # Wait longer between attempts
-                    }
-                    
-                    if ($ssh_connection->test_password_connection()) {
-                        say "✅ SSH connection re-established!";
-                        STDOUT->flush();
-                        $consecutive_ssh_failures = 0; # Reset counter after successful reconnection
-                    } else {
-                        say "❌ Failed to re-establish SSH connection after VM reboot.";
-                        say "  [DEBUG] Last error: " . $result->output;
-                        STDOUT->flush();
-                        last;
-                    }
-                }
-            } else {
-                # Reset counter for non-SSH failures (normal file-not-found errors)
-                $consecutive_ssh_failures = 0;
-            }
-            
-            # Debug: Show why the command failed
-            if ($attempt % 6 == 0) { # Every 30 seconds
-                my $elapsed_seconds = $attempt * 5;
-                say "   [DEBUG ${elapsed_seconds}s] File check failed - Exit code: " . $result->exit_code . 
-                    " (this is normal until cloud-init completes)";
-                if ($consecutive_ssh_failures > 0) {
-                    say "    [SSH failures: $consecutive_ssh_failures consecutive]";
-                }
-                STDOUT->flush();
-            }
-        }
-        
-        # Show progress indicator every 2 minutes
-        if ($attempt % 24 == 0) {
-            my $elapsed_minutes = int($attempt * 5 / 60);
-            say "  [Cloud-init still running... ${elapsed_minutes} minutes elapsed]";
-            STDOUT->flush();
-        }
-        
-        sleep(5);
-    }
-    
-    if (!$cloud_init_success) {
-        say "❌ Timeout waiting for cloud-init to complete on " . $ssh_connection->host . " after " . ($max_attempts * 5 / 60) . " minutes";
-        STDOUT->flush();
-        $self->_print_cloud_init_logs($ssh_connection);
-        die "Cloud-init timeout";
-    }
-}
-
-sub _print_cloud_init_logs {
-    my ($self, $ssh_connection) = @_;
-    
-    say "📄 Cloud-init logs (for debugging):";
-    
-    # Print cloud-init-output.log
-    say "=== /var/log/cloud-init-output.log ===";
-    my $output_result = $ssh_connection->execute_command_with_sudo('cat /var/log/cloud-init-output.log');
-    if ($output_result->success) {
-        print $output_result->output;
-    } else {
-        say "Cloud-init output log not available";
-    }
-    
-    say "=== /var/log/cloud-init.log ===";
-    my $main_result = $ssh_connection->execute_command_with_sudo('cat /var/log/cloud-init.log');
-    if ($main_result->success) {
-        print $main_result->output;
-    } else {
-        say "Cloud-init main log not available";
-    }
-}
-
-sub _run_ansible_verification {
-    my ($self, $vm_ip, $work_dir) = @_;
-    
-    say "";
-    say "🎭 Starting Ansible post-provision verification...";
-    STDOUT->flush();
-    
-    # Set up Ansible working directory
-    my $ansible_dir = $work_dir->child('ansible');
-    
-    # Create Ansible instance and set up configuration
-    my $ansible = TorrustDeploy::Provision::Ansible->new();
-    $ansible->copy_templates_and_generate_inventory($vm_ip, $ansible_dir);
-    
-    # Run verification playbook
-    $ansible->run_verification($ansible_dir);
-}
-
 1;
 
 __END__
@@ -299,8 +127,8 @@ TorrustDeploy::App::Command::Provision - Provision Torrust Tracker VM
 =head1 DESCRIPTION
 
 Provisions a Torrust Tracker virtual machine using OpenTofu with the libvirt provider.
-Creates a minimal Ubuntu 24.04 LTS VM, waits for IP assignment, and monitors cloud-init 
-completion via SSH.
+Creates a minimal Ubuntu 24.04 LTS VM, waits for cloud-init completion using Ansible,
+runs post-provision verification, and performs a clean VM restart.
 
 =head1 USAGE
 
@@ -309,10 +137,9 @@ completion via SSH.
 =head1 REQUIREMENTS
 
 - OpenTofu installed
-- Ansible installed
+- Ansible installed (with community.general collection for cloud_init module)
 - libvirt/KVM installed and running
 - qemu-system-x86_64
-- sshpass installed (for password authentication during cloud-init monitoring)
 - Testing SSH key pair (~/.ssh/testing_rsa)
 - Default libvirt storage pool configured
 - Template files in templates/ directory (main.tf, cloud-init.yml, ansible/)

lib/TorrustDeploy/Provision/Ansible.pm

@@ -63,17 +63,25 @@ sub copy_templates_and_generate_inventory {
     $ansible_cfg_template->copy($ansible_cfg_dest);
     say "Copied: $ansible_cfg_template -> $ansible_cfg_dest";
 
-    # Copy playbooks
-    my $verification_template = $templates_dir->child('post-provision-verification.yml');
-    my $verification_dest = $ansible_dir->child('post-provision-verification.yml');
-    
-    unless ($verification_template->exists) {
-        die "Verification playbook template not found: $verification_template";
+    # Copy all playbooks
+    my @playbooks = (
+        'wait-for-cloud-init.yml',
+        'post-provision-verification.yml',
+        'restart-vm.yml'
+    );
+    
+    for my $playbook (@playbooks) {
+        my $template = $templates_dir->child($playbook);
+        my $dest = $ansible_dir->child($playbook);
+        
+        unless ($template->exists) {
+            die "Playbook template not found: $template";
+        }
+        
+        $template->copy($dest);
+        say "Copied: $template -> $dest";
     }
 
-    $verification_template->copy($verification_dest);
-    say "Copied: $verification_template -> $verification_dest";
-    
     # Generate inventory with VM IP
     my $inventory_template = $templates_dir->child('inventory.ini.template');
     my $inventory_dest = $ansible_dir->child('inventory.ini');
@@ -93,6 +101,31 @@ sub copy_templates_and_generate_inventory {
     say "Ansible setup completed successfully.";
 }
 
+=head2 wait_for_cloud_init
+
+Wait for cloud-init completion using Ansible playbook.
+
+    $ansible->wait_for_cloud_init($ansible_dir);
+
+=cut
+
+sub wait_for_cloud_init {
+    my ($self, $ansible_dir) = @_;
+    
+    say "⏳ Waiting for cloud-init completion using Ansible...";
+    STDOUT->flush();
+    
+    # Change to ansible directory and run cloud-init wait playbook
+    my $result = system("cd '$ansible_dir' && ansible-playbook -i inventory.ini wait-for-cloud-init.yml");
+    
+    if ($result != 0) {
+        die "Ansible cloud-init wait failed with exit code: $result";
+    }
+    
+    say "✅ Cloud-init completion verified via Ansible!";
+    STDOUT->flush();
+}
+
 =head2 run_verification
 
 Run the post-provision verification playbook.
@@ -118,6 +151,31 @@ sub run_verification {
     STDOUT->flush();
 }
 
+=head2 restart_vm
+
+Restart the VM after post-provision verification.
+
+    $ansible->restart_vm($ansible_dir);
+
+=cut
+
+sub restart_vm {
+    my ($self, $ansible_dir) = @_;
+    
+    say "🔄 Restarting VM using Ansible...";
+    STDOUT->flush();
+    
+    # Change to ansible directory and run restart playbook
+    my $result = system("cd '$ansible_dir' && ansible-playbook -i inventory.ini restart-vm.yml");
+    
+    if ($result != 0) {
+        die "Ansible VM restart failed with exit code: $result";
+    }
+    
+    say "✅ VM restart completed successfully!";
+    STDOUT->flush();
+}
+
 1;
 
 __END__

project-words.txt

@@ -23,6 +23,7 @@ keygen
 keyrings
 libssh
 libvirtd
+loadavg
 LOGLEVEL
 memtotal
 mkpath