refactor: rename VM instance from 'torrust-vm' to 'torrust-tracker-vm'

- Update Ansible inventory template with new instance name
- Update all hardcoded references in Rust source code
- Update test assertions and mock data
- Update documentation and GitHub workflows
- Update OpenTofu variable references in comments
- Maintain backward compatibility while preparing for multiple Torrust application VMs

All linters, unit tests, and core e2e functionality verified to work with the new naming.

Author: josecelano

.github/workflows/test-e2e.yml

@@ -74,10 +74,10 @@ jobs:
           sudo -E tofu output || echo "No outputs available"
 
           echo "=== Container Status ==="
-          sudo lxc list torrust-vm || echo "Container not found"
+          sudo lxc list torrust-tracker-vm || echo "Container not found"
 
-          echo "=== Container Info ==="
-          sudo lxc info torrust-vm || echo "Container info not available"
+          # Check if the container has an IP address before proceeding
+          sudo lxc info torrust-tracker-vm || echo "Container info not available"
 
       - name: Debug information (on failure)
         if: failure()
@@ -104,7 +104,7 @@ jobs:
           # Use sudo for CI environment cleanup
           # NOTE: For local development, use "sg lxd -c 'tofu destroy'" instead
           sudo -E tofu destroy -auto-approve || echo "Destroy command failed or nothing to destroy"
-          sudo lxc delete torrust-vm --force || echo "Container deletion failed or container doesn't exist"
+          sudo lxc delete torrust-tracker-vm --force || echo "Container deletion failed or container doesn't exist"
 
       - name: Final verification
         if: always()

.github/workflows/test-lxd-provision.yml

@@ -109,7 +109,7 @@ jobs:
           timeout=300
           elapsed=0
           while [ $elapsed -lt $timeout ]; do
-            if lxc exec torrust-vm -- test -f /tmp/provision_complete 2>/dev/null; then
+            if lxc exec torrust-tracker-vm -- test -f /tmp/provision_complete 2>/dev/null; then
               echo "Container provisioning completed successfully!"
               break
             fi
@@ -127,35 +127,35 @@ jobs:
         run: |
           # Test basic connectivity
           lxc list
-          lxc info torrust-vm
+          lxc info torrust-tracker-vm
 
           # Test command execution
-          lxc exec torrust-vm -- whoami
+          lxc exec torrust-tracker-vm -- whoami
 
           # Test system information with error handling
           echo "Getting system information..."
-          lxc exec torrust-vm -- cat /etc/os-release || echo "os-release failed"
+          lxc exec torrust-tracker-vm -- cat /etc/os-release || echo "os-release failed"
           sleep 1
 
-          lxc exec torrust-vm -- df -h || echo "df failed"
+          lxc exec torrust-tracker-vm -- df -h || echo "df failed"
           sleep 1
 
-          lxc exec torrust-vm -- free -h || echo "free failed"
+          lxc exec torrust-tracker-vm -- free -h || echo "free failed"
           sleep 1
 
           # Test cloud-init functionality
           echo "Testing cloud-init..."
-          lxc exec torrust-vm -- cloud-init status || echo "cloud-init status failed"
+          lxc exec torrust-tracker-vm -- cloud-init status || echo "cloud-init status failed"
           sleep 1
 
           # Test user creation
           echo "Testing user creation..."
-          lxc exec torrust-vm -- id torrust || echo "torrust user not found"
+          lxc exec torrust-tracker-vm -- id torrust || echo "torrust user not found"
           sleep 1
 
           # Test systemd services
           echo "Testing systemd..."
-          lxc exec torrust-vm -- systemctl status ssh || echo "ssh service check failed"
+          lxc exec torrust-tracker-vm -- systemctl status ssh || echo "ssh service check failed"
 
       - name: Get container outputs
         working-directory: build/tofu/lxd
@@ -169,7 +169,7 @@ jobs:
           # Use tofu without sudo since socket permissions are set up
           # NOTE: For local development, use "sg lxd -c 'tofu destroy'" instead
           tofu destroy -auto-approve || true
-          lxc delete torrust-vm --force || true
+          lxc delete torrust-tracker-vm --force || true
 
       - name: Final verification
         if: always()

README.md

@@ -162,11 +162,10 @@ ansible-playbook install-docker-compose.yml
 #### 3. Verify Deployment
 
 ```bash
-# Check VM status
-lxc list torrust-vm
+lxc list torrust-tracker-vm
 
-# Connect to VM
-lxc exec torrust-vm -- /bin/bash
+# Access the container directly
+lxc exec torrust-tracker-vm -- /bin/bash
 
 # Test SSH connection
 ssh -i ~/.ssh/testing_rsa torrust@<VM_IP>

docs/e2e-testing.md

@@ -117,8 +117,8 @@ If tests fail and leave resources behind, you can manually clean up:
 lxc list
 
 # Stop and delete the test container
-lxc stop torrust-vm
-lxc delete torrust-vm
+lxc stop torrust-tracker-vm
+lxc delete torrust-tracker-vm
 
 # Or use OpenTofu to clean up
 cd build/tofu/lxd
@@ -164,7 +164,7 @@ Use the `--keep` flag to inspect the environment after test completion:
 cargo run --bin e2e-tests -- --keep
 
 # After test completion, connect to the container:
-lxc exec torrust-vm -- /bin/bash
+lxc exec torrust-tracker-vm -- /bin/bash
 ```
 
 ## 🏗️ Architecture

docs/refactors/instance-name-parameterization.md

@@ -2,7 +2,7 @@
 
 ## Overview
 
-This refactor aims to eliminate hardcoded "torrust-vm" instance names throughout the codebase and replace them with parameterized values. The goal is to enable dynamic instance naming for different environments and support running multiple instances simultaneously.
+This refactor aims to eliminate hardcoded "torrust-tracker-vm" instance names throughout the codebase and replace them with parameterized values. The goal is to enable dynamic instance naming for different environments and support running multiple instances simultaneously.
 
 ## 📊 Progress Status
 
@@ -45,7 +45,7 @@ This refactor aims to eliminate hardcoded "torrust-vm" instance names throughout
 All planned phases for instance name parameterization have been successfully implemented. The refactor is complete with the following achievements:
 
 - **Instance names are now configurable** through the `Config` struct and E2E test environment
-- **Hardcoded "torrust-vm" values eliminated** from key infrastructure components
+- **Hardcoded "torrust-tracker-vm" values eliminated** from key infrastructure components
 - **Template system supports dynamic instance naming** via Tera templating
 - **E2E tests can use custom instance names** while maintaining backward compatibility
 - **All quality gates passed**: linters, unit tests, and e2e tests successful
@@ -71,7 +71,7 @@ All planned phases for instance name parameterization have been successfully imp
 - ✅ Create `templates/tofu/lxd/variables.tfvars` template file to define `instance_name` variable
 - ✅ Update `TofuTemplateRenderer` to include this file in static template copying
 - ✅ Keep `image` variable static (not templated)
-- **Status**: Static variables file created with hardcoded "torrust-vm" value
+- **Status**: Static variables file created with hardcoded "torrust-tracker-vm" value
 - **Validation**: ✅ Unit tests + linters + e2e tests passed
 
 #### Step 1b: Update OpenTofu client for variables file ✅
@@ -112,9 +112,9 @@ All planned phases for instance name parameterization have been successfully imp
 - ✅ Created `render_variables_template()` method for dynamic rendering
 - ✅ Updated `render_tera_templates()` to call variables template rendering
 - ✅ Removed `variables.tfvars` from static template files list
-- ✅ Added hardcoded "torrust-vm" values for backward compatibility
+- ✅ Added hardcoded "torrust-tracker-vm" values for backward compatibility
 - ✅ Updated all test constructors to include `instance_name` parameter
-- **Status**: Variables template now dynamically renders with `instance_name = "torrust-vm"`
+- **Status**: Variables template now dynamically renders with `instance_name = "torrust-tracker-vm"`
 - **Validation**: ✅ All linters + unit tests + e2e tests passed
 
 ### Phase 3: Context Integration ✅
@@ -137,7 +137,7 @@ Instead of the originally planned `TofuContext` approach, we implemented instanc
 - ✅ Added `instance_name` parameter to `TestEnvironment::with_ssh_user()` in `src/e2e/environment.rs`
 - ✅ Updated `TestEnvironment::with_ssh_user_and_init()` to accept `instance_name` parameter
 - ✅ Updated `create_config()` helper function to accept `instance_name` parameter
-- ✅ Maintained backward compatibility with existing `new()` functions using hardcoded "torrust-vm"
+- ✅ Maintained backward compatibility with existing `new()` functions using hardcoded "torrust-tracker-vm"
 - **Status**: E2E test infrastructure can now create environments with custom instance names
 - **Validation**: ✅ All linters + unit tests + e2e tests passed
 
@@ -147,7 +147,7 @@ Instead of the originally planned `TofuContext` approach, we implemented instanc
 
 - ✅ Updated `TestEnvironment::new()` method in `src/e2e/environment.rs` to accept `instance_name: &str` parameter
 - ✅ Updated `TestEnvironment::new_and_init()` method to accept `instance_name` parameter
-- ✅ Added `instance_name` variable in `main()` function of `src/bin/e2e_tests.rs` with hardcoded "torrust-vm" value
+- ✅ Added `instance_name` variable in `main()` function of `src/bin/e2e_tests.rs` with hardcoded "torrust-tracker-vm" value
 - ✅ Updated method call to pass `instance_name` from main to `TestEnvironment::new()`
 - ✅ Added proper documentation with `# Panics` section for clippy compliance
 - ✅ Updated documentation example in `src/e2e/tasks/preflight_cleanup.rs` to use new signature
@@ -169,7 +169,7 @@ The implementation evolved from the original plan due to codebase changes:
 
 ### 🎯 Outcomes
 
-- **Hardcoded Instances Eliminated**: Key hardcoded "torrust-vm" strings removed from infrastructure provisioning
+- **Hardcoded Instances Eliminated**: Key hardcoded "torrust-tracker-vm" strings removed from infrastructure provisioning
 - **Dynamic Instance Naming**: Instance names can now be configured at runtime through the Config struct
 - **Test Environment Flexibility**: E2E tests can create environments with custom instance names
 - **Configuration Centralization**: All instance name handling flows through the `Config` struct
@@ -187,14 +187,14 @@ The implementation evolved from the original plan due to codebase changes:
 **Results**:
 
 - Instance names configurable through `Config` struct and E2E main function
-- All hardcoded "torrust-vm" references eliminated from core infrastructure
+- All hardcoded "torrust-tracker-vm" references eliminated from core infrastructure
 - All tests passing (linters, 259 unit tests, e2e deployment tests)
 - Zero unused dependencies
 - Full backward compatibility maintained
 
-## 🔍 Analysis of Current "torrust-vm" Usage
+## 🔍 Analysis of Current "torrust-tracker-vm" Usage
 
-Currently, the instance name "torrust-vm" is hardcoded in multiple places across the codebase, including:
+Currently, the instance name "torrust-tracker-vm" is hardcoded in multiple places across the codebase, including:
 
 - Infrastructure configuration files (OpenTofu templates)
 - Rust code literals and variables
@@ -207,9 +207,9 @@ This creates several issues:
 - Hard to customize instance names for different environments
 - Tight coupling between configuration and implementation
 
-## Summary of "torrust-vm" Usage Analysis
+## Summary of "torrust-tracker-vm" Usage Analysis
 
-Based on a comprehensive search through the codebase, **61 occurrences** of "torrust-vm" were found across 4 main categories:
+Based on a comprehensive search through the codebase, **61 occurrences** of "torrust-tracker-vm" were found across 4 main categories:
 
 ### 1. Configuration Files (2 files, 7 occurrences)
 
@@ -340,7 +340,7 @@ Start from low-level infrastructure details and work up to higher abstractions:
 ## Success Criteria
 
 - [ ] Instance name defined once in `src/bin/e2e_tests.rs`
-- [ ] All hardcoded "torrust-vm" references eliminated
+- [ ] All hardcoded "torrust-tracker-vm" references eliminated
 - [ ] OpenTofu uses variables file for parameterization
 - [ ] All tests (unit, linting, e2e) pass at each step
 - [ ] No regression in functionality

docs/tofu-lxd-configuration.md

@@ -162,7 +162,7 @@ Before provisioning, you may want to customize:
 
 1. **SSH Key**: Edit the `cloud-init.yml` file and replace the SSH key with your actual public key
 2. **Container Specifications**: Adjust resource limits in `main.tf`
-3. **Container Name**: Change the instance name from "torrust-vm" to your preferred name
+3. **Container Name**: Change the instance name from "torrust-tracker-vm" to your preferred name
 4. **Packages**: Modify the packages list in `cloud-init.yml` to include additional software
 
 ## Provisioning
@@ -210,7 +210,7 @@ To provision the container:
    instance_info = {
      "image" = "ubuntu:22.04"
      "ip_address" = "10.140.190.155"
-     "name" = "torrust-vm"
+     "name" = "torrust-tracker-vm"
      "status" = "Running"
    }
    ```
@@ -223,81 +223,79 @@ To provision the container:
 
 6. **Access the container**:
 
-   ```bash
-   # Direct shell access
-   lxc exec torrust-vm -- /bin/bash
-
-   # If you have LXD permission issues, use:
-   sg lxd -c "lxc exec torrust-vm -- /bin/bash"
+````bash
+# Direct shell access
+lxc exec torrust-tracker-vm -- /bin/bash
 
-   # SSH access (if you configured your SSH key and networking)
-   ssh torrust@<container-ip-address>
-   ```
+# Or if you need to use the lxd group:
+sg lxd -c "lxc exec torrust-tracker-vm -- /bin/bash"
 
-## Managing the Container
+# SSH access (if you configured your SSH key and networking)
+ssh torrust@<container-ip-address>
+```## Managing the Container
 
-After provisioning, you can manage the `torrust-vm` container using standard LXD commands:
+After provisioning, you can manage the `torrust-tracker-vm` container using standard LXD commands:
 
 ### Access the Container
 
 ```bash
 # Direct shell access
-lxc exec torrust-vm -- /bin/bash
+lxc exec torrust-tracker-vm -- /bin/bash
 
-# If you have LXD permission issues, use:
-sg lxd -c "lxc exec torrust-vm -- /bin/bash"
+# Or if you need to use the lxd group:
+sg lxd -c "lxc exec torrust-tracker-vm -- /bin/bash"
 
 # SSH access (if you configured your SSH key and networking)
 ssh torrust@<container-ip-address>
-```
+````
 
 ### Check Container Status
 
 ```bash
 # Check the status of our specific container
-lxc info torrust-vm
+lxc info torrust-tracker-vm
 
-# List all containers (including torrust-vm)
+# List all containers (including torrust-tracker-vm)
 lxc list
 ```
 
 ### Container Lifecycle
 
 ```bash
 # Stop the container
-lxc stop torrust-vm
+lxc stop torrust-tracker-vm
 
 # Start the container
-lxc start torrust-vm
+lxc start torrust-tracker-vm
 
 # Restart the container
-lxc restart torrust-vm
+lxc restart torrust-tracker-vm
 ```
 
 ### Common Operations
 
 ```bash
 # Check if cloud-init provisioning completed
-lxc exec torrust-vm -- cat /tmp/provision_complete
+lxc exec torrust-tracker-vm -- cat /tmp/provision_complete
 
 # Check system information
-lxc exec torrust-vm -- lsb_release -a
+lxc exec torrust-tracker-vm -- lsb_release -a
 
 # Check systemd services (works in LXD system containers!)
-lxc exec torrust-vm -- systemctl status ssh
+lxc exec torrust-tracker-vm -- systemctl status ssh
 
 # Install additional packages (if needed during development)
-lxc exec torrust-vm -- sudo apt update
-lxc exec torrust-vm -- sudo apt install -y git curl wget htop vim
+lxc exec torrust-tracker-vm -- sudo apt update
+lxc exec torrust-tracker-vm -- sudo apt install -y git curl wget htop vim
 
 # Check available disk space
-lxc exec torrust-vm -- df -h
+lxc exec torrust-tracker-vm -- df -h
 
 # Check running processes
-lxc exec torrust-vm -- ps aux
+lxc exec torrust-tracker-vm -- ps aux
 
 # Check cloud-init status
-lxc exec torrust-vm -- cloud-init status
+lxc exec torrust-tracker-vm -- cloud-init status
 ```
 
 For more LXD commands and troubleshooting, see the [LXD documentation](../../docs/tech-stack/lxd.md).

src/ansible/template/renderer/inventory.rs

@@ -224,7 +224,7 @@ mod tests {
 
         let template_content = r#"all:
   hosts:
-    torrust-vm:
+    torrust-tracker-vm:
       ansible_host: {{ ansible_host }}
       ansible_user: torrust
       ansible_connection: ssh
@@ -314,7 +314,7 @@ mod tests {
         // Template requires {{ non_existent_field }} which won't be in context
         let template_content = r"all:
   hosts:
-    torrust-vm:
+    torrust-tracker-vm:
       ansible_host: {{ ansible_host }}
       ansible_user: torrust
       missing_field: {{ non_existent_field }}